Stabilize flaky E2E waits for TOC init and dynamic tag selection#447
Merged
Conversation
Closed
Copilot
AI
changed the title
[WIP] Fix flaky end to end tests for sidebar TOC
Stabilize flaky E2E waits for TOC init and dynamic tag selection
May 29, 2026
Contributor
⏰ PR Preview Environment — Nightly TeardownThe preview environment was automatically torn down as part of the nightly cleanup (23:00 Brussels time). To resume testing:
|
rvanmaanen
marked this pull request as ready for review
May 29, 2026 15:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two E2E tests were intermittently timing out due to brittle readiness conditions: TOC initialization depended solely on
window.__e2esignals, and dynamic-tag setup depended on URL mutation timing. This change hardens both waits to assert stable UI state directly.TOC readiness fallback in E2E helper
WaitForTocInitializedAsyncto keep signal-based waiting whenwindow.__e2eexists, but fall back to DOM readiness when it does not.State-based setup in dynamic tag flake paths
tags=in URL with assertions that selected-tag count increases after click.Representative change