Skip to content

Commit b3a24ed

Browse files
committed
✅ streamline MySQL connection setup in tests for clarity
1 parent c5810d7 commit b3a24ed

1 file changed

Lines changed: 16 additions & 20 deletions

File tree

tests/func/mysql_to_sqlite3_test.py

Lines changed: 16 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -457,16 +457,14 @@ def test_transfer_transfers_all_tables_from_mysql_to_sqlite(
457457
mysql_inspect: Inspector = inspect(mysql_engine)
458458
mysql_tables: t.List[str] = mysql_inspect.get_table_names()
459459

460-
mysql_connector_connection: t.Union[PooledMySQLConnection, MySQLConnectionAbstract] = (
461-
mysql.connector.connect(
462-
user=mysql_credentials.user,
463-
password=mysql_credentials.password,
464-
host=mysql_credentials.host,
465-
port=mysql_credentials.port,
466-
database=mysql_credentials.database,
467-
charset="utf8mb4",
468-
collation="utf8mb4_unicode_ci",
469-
)
460+
mysql_connector_connection: t.Union[PooledMySQLConnection, MySQLConnectionAbstract] = mysql.connector.connect(
461+
user=mysql_credentials.user,
462+
password=mysql_credentials.password,
463+
host=mysql_credentials.host,
464+
port=mysql_credentials.port,
465+
database=mysql_credentials.database,
466+
charset="utf8mb4",
467+
collation="utf8mb4_unicode_ci",
470468
)
471469
server_version: t.Tuple[int, ...] = mysql_connector_connection.get_server_version()
472470

@@ -1207,16 +1205,14 @@ def test_transfer_limited_rows_from_mysql_to_sqlite(
12071205
mysql_inspect: Inspector = inspect(mysql_engine)
12081206
mysql_tables: t.List[str] = mysql_inspect.get_table_names()
12091207

1210-
mysql_connector_connection: t.Union[PooledMySQLConnection, MySQLConnectionAbstract] = (
1211-
mysql.connector.connect(
1212-
user=mysql_credentials.user,
1213-
password=mysql_credentials.password,
1214-
host=mysql_credentials.host,
1215-
port=mysql_credentials.port,
1216-
database=mysql_credentials.database,
1217-
charset="utf8mb4",
1218-
collation="utf8mb4_unicode_ci",
1219-
)
1208+
mysql_connector_connection: t.Union[PooledMySQLConnection, MySQLConnectionAbstract] = mysql.connector.connect(
1209+
user=mysql_credentials.user,
1210+
password=mysql_credentials.password,
1211+
host=mysql_credentials.host,
1212+
port=mysql_credentials.port,
1213+
database=mysql_credentials.database,
1214+
charset="utf8mb4",
1215+
collation="utf8mb4_unicode_ci",
12201216
)
12211217
server_version: t.Tuple[int, ...] = mysql_connector_connection.get_server_version()
12221218

0 commit comments

Comments
 (0)