Skip to content

Commit d30ad90

Browse files
committed
Remove gsutil
1 parent 25e5a23 commit d30ad90

3 files changed

Lines changed: 26 additions & 229 deletions

File tree

.github/workflows/snapshot-deploy.yml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: Build and Deploy
1+
name: Snapshot Deploy
22

33
on:
44
push:
@@ -115,9 +115,6 @@ jobs:
115115
steps:
116116
- uses: actions/checkout@v4
117117

118-
- name: Fix gsutil dependency
119-
run: pip install six
120-
121118
- name: Build native code (macOS arm64)
122119
run: |
123120
cd native && mkdir build && cd build
@@ -169,9 +166,6 @@ jobs:
169166
steps:
170167
- uses: actions/checkout@v4
171168

172-
- name: Fix gsutil dependency
173-
run: pip install six
174-
175169
- name: Build native code (Windows)
176170
run: |
177171
cd native

native/CMakeLists.txt

Lines changed: 25 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -259,42 +259,41 @@ endif()
259259
# make_readme.py script.
260260
file(COPY "${CEF_ROOT}/README.txt" DESTINATION "${CMAKE_BINARY_DIR}")
261261

262-
# Download clang-format from Google Storage.
262+
# Download clang-format directly from Google Storage.
263263
if(OS_WINDOWS)
264-
set(GS_PLATFORM "win32")
265-
set(GS_HASHPATH "win/clang-format.exe.sha1")
266-
set(GS_OUTPATH "win/clang-format.exe")
264+
set(CF_HASHFILE "tools/buildtools/win/clang-format.exe.sha1")
265+
set(CF_OUTPATH "${CMAKE_CURRENT_SOURCE_DIR}/tools/buildtools/win/clang-format.exe")
267266
elseif(OS_MACOSX)
268-
set(GS_PLATFORM "darwin")
269267
if("${CMAKE_HOST_SYSTEM_PROCESSOR}" STREQUAL "arm64")
270-
set(GS_HASHPATH "mac/clang-format.arm64.sha1")
268+
set(CF_HASHFILE "tools/buildtools/mac/clang-format.arm64.sha1")
271269
else()
272-
set(GS_HASHPATH "mac/clang-format.x64.sha1")
270+
set(CF_HASHFILE "tools/buildtools/mac/clang-format.x64.sha1")
273271
endif()
274-
set(GS_OUTPATH "mac/clang-format")
272+
set(CF_OUTPATH "${CMAKE_CURRENT_SOURCE_DIR}/tools/buildtools/mac/clang-format")
275273
elseif(OS_LINUX)
276-
set(GS_PLATFORM "linux*")
277-
set(GS_HASHPATH "linux64/clang-format.sha1")
278-
set(GS_OUTPATH "linux64/clang-format")
274+
set(CF_HASHFILE "tools/buildtools/linux64/clang-format.sha1")
275+
set(CF_OUTPATH "${CMAKE_CURRENT_SOURCE_DIR}/tools/buildtools/linux64/clang-format")
279276
endif()
280277

281278
message(STATUS "Downloading clang-format from Google Storage...")
282-
execute_process(
283-
COMMAND "${PYTHON_EXECUTABLE}"
284-
"tools/buildtools/download_from_google_storage.py"
285-
"--no_resume"
286-
"--platform=${GS_PLATFORM}"
287-
"--no_auth"
288-
"--bucket" "chromium-clang-format"
289-
"-s" "tools/buildtools/${GS_HASHPATH}"
290-
"-o" "tools/buildtools/${GS_OUTPATH}"
291-
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
292-
RESULT_VARIABLE EXECUTE_RV
293-
)
294-
if(NOT EXECUTE_RV STREQUAL "0")
295-
message(FATAL_ERROR "Execution failed with unexpected result: ${EXECUTE_RV}")
279+
file(READ "${CMAKE_CURRENT_SOURCE_DIR}/${CF_HASHFILE}" CF_HASH)
280+
string(STRIP "${CF_HASH}" CF_HASH)
281+
file(DOWNLOAD
282+
"https://storage.googleapis.com/chromium-clang-format/${CF_HASH}"
283+
"${CF_OUTPATH}"
284+
STATUS DOWNLOAD_STATUS
285+
SHOW_PROGRESS
286+
)
287+
list(GET DOWNLOAD_STATUS 0 DOWNLOAD_STATUS_CODE)
288+
if(NOT DOWNLOAD_STATUS_CODE EQUAL 0)
289+
message(FATAL_ERROR "Failed to download clang-format: ${DOWNLOAD_STATUS}")
290+
endif()
291+
if(NOT OS_WINDOWS)
292+
file(CHMOD "${CF_OUTPATH}" PERMISSIONS
293+
OWNER_READ OWNER_WRITE OWNER_EXECUTE
294+
GROUP_READ GROUP_EXECUTE
295+
WORLD_READ WORLD_EXECUTE)
296296
endif()
297-
298297

299298
#
300299
# Include target subdirectories.

native/tools/buildtools/gsutil.py

Lines changed: 0 additions & 196 deletions
This file was deleted.

0 commit comments

Comments
 (0)