Skip to content

Commit a218bd0

Browse files
committed
Refactor code related to nativeAccessEnabled
1 parent 2bdef79 commit a218bd0

2 files changed

Lines changed: 4 additions & 9 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -326,7 +326,7 @@ A configuration template with all supported tags:
326326
<Module groupId="..." artifactId="..." version="..."/>
327327
</If>
328328
329-
<Module groupId="..." artifactId="..." version="${config['modVersion']}" active="true">
329+
<Module groupId="..." artifactId="..." version="${config['modVersion']}" active="true" nativeAccessEnabled="true>
330330
<Directives>
331331
<Directive type="opens/reads/exports" package="..." layer="..." module="..."/>
332332
<Directive type="requestsOpen/requestsRead/requestsExport" layer="..." module="..." package="..."/>

alpha-core/src/main/java/com/techsenger/alpha/core/impl/LayerBuilder.java

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ private void doBuild(final DefaultComponent component, final ModuleFinder module
215215
ModuleLayer.Controller controller =
216216
ModuleLayer.defineModulesWithOneLoader(cf, parentLayers, parentClassLoader);
217217
component.setLayerController(controller);
218-
addModuleDirectives(component);
218+
configureModules(component);
219219
Set<ClassLoader> cachedClassLoaders = new HashSet<>();
220220
controller.layer()
221221
.modules()
@@ -231,13 +231,7 @@ private void doBuild(final DefaultComponent component, final ModuleFinder module
231231
}
232232
}
233233

234-
/**
235-
* It is impossible to get reference to boot layer controller in JPMS, so, we can only use module and
236-
* JVM arguments add-*.
237-
*
238-
* @param component
239-
*/
240-
private void addModuleDirectives(DefaultComponent component) {
234+
private void configureModules(DefaultComponent component) {
241235
var descriptor = component.getDescriptor();
242236
var config = descriptor.getConfig();
243237
var resolvedDirectives = new ArrayList<ResolvedModuleDirective>();
@@ -254,6 +248,7 @@ private void addModuleDirectives(DefaultComponent component) {
254248
}
255249
}
256250
}
251+
// native access is not a directive
257252
if (m.isNativeAccessEnabled()) {
258253
component.getLayerController().enableNativeAccess(module);
259254
if (logger.isDebugEnabled()) {

0 commit comments

Comments
 (0)