Skip to content

Merge changes from swan-integration#12

Open
techtocore wants to merge 3 commits into
masterfrom
test
Open

Merge changes from swan-integration#12
techtocore wants to merge 3 commits into
masterfrom
test

Conversation

@techtocore

Copy link
Copy Markdown
Owner

Signed-off-by: Akash Ravi akashkravi@gmail.com

Signed-off-by: Akash Ravi <akashkravi@gmail.com>
@techtocore techtocore requested a review from diocas September 1, 2019 18:50
Signed-off-by: Akash Ravi <akashkravi@gmail.com>

@diocas diocas left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some doubts.

Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread extension/js/extension.js Outdated
Comment thread extension/js/methods.js

#package-name {
width: 390px;
width: 380px;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you need to have this with fixed size?

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having a 100% width seems to break the searchbar's dimensions. I'll check if there is any better alternative, compared to hardcoding the width.

@diocas

diocas commented Oct 28, 2019

Copy link
Copy Markdown
Collaborator

Any news?

Signed-off-by: Akash Ravi <akashkravi@gmail.com>
@diocas

diocas commented Nov 6, 2019

Copy link
Copy Markdown
Collaborator

Let me know when this can be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants