Conversation
…hem available with slightly different url scheme
…to do what we really need it to do (simplifying it too)
✅ Deploy Preview for techworkersco ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…make entire button in navigation clickable (fixed inconsistent hover behaviour and made it easier to click too)
…yles for SVG icons and for images. Blog itself searches for either explicitly enclosed file in front matter or finds any image. If none are found, then it uses a blog SVG icon
…icating front matter, perhaps because interpolation was not easy to figure out
There was a problem hiding this comment.
Pull Request Overview
This PR merges two distinct newsletters into one unified repository while preserving all historical newsletter content and fixing broken Liquid inclusions. The key changes include:
- Importing over 130 newsletter markdown files from a separate repository.
- Fixing broken Liquid include tags and related image/link metadata.
- Updating the Gemfile to use a new internationalization plugin.
Reviewed Changes
Copilot reviewed 349 out of 349 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| _blog/*.md | New markdown files for each historical newsletter issue with content imports and minor formatting fixes. |
| Gemfile | Updated the jekyll language plugin dependency from the old repository to "techworkersco/jekyll-i18n". |
Comments suppressed due to low confidence (2)
Gemfile:24
- The gem reference was updated to point to a new repository. Please verify that the new plugin 'jekyll-i18n' provides equivalent multilingual support and update any related documentation accordingly.
gem "jekyll-multiple-languages-plugin", github: "techworkersco/jekyll-i18n"
_blog/*.md:1
- [nitpick] Ensure that the YAML front matter across all new markdown posts is consistent (e.g., alt text, caption, and image fields) to maintain uniformity with the site standards.
---
…e-height to 1.5 for increased readability. Further spacing/breathing css forthcoming. Instead of unhelpful next/previous button, show previous of before/after blog posts.
…us/next" previous
Member
Author
|
Fixed some bugs with Gershom (if new bugs were introduced, all the blame is shared jk jk) |
shushugah
added a commit
that referenced
this pull request
Apr 2, 2025
# Goal: unify two different newsletters for decreased complexity ## Background Currently there is a repostory https://github.com/techworkersco/techworkersco.github.io/ hosting https://news.techworkerscoalition.org and this repostory hosting https://techworkerscoalition.org/blog ## Second approach Copying all 135 newsletter posts from https://github.com/techworkersco/techworkersco.github.io here (hence large PR request) and fixing broken liquid inclusions. * Did not prioritize adding all CSS, as it had extra libraries and very manual process. We can use domain rules, so that something hosted at `news.techworkerscoalition.org/foo` gets redirected to `techworkerscoalition.org/blog/foo` for example https://news.techworkerscoalition.org/2023/06/13/issue-10/ is available at https://deploy-preview-418--techworkersco.netlify.app/blog/2023/06/13/issue-10 ### Pros * One unified repository * One image library * More familiar code-base to maintain * All images/links are working/fixed now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal: unify two different newsletters for decreased complexity
Background
Currently there is a repository https://github.com/techworkersco/techworkersco.github.io/ hosting https://news.techworkerscoalition.org and this repostory hosting https://techworkerscoalition.org/blog
PR Changes
Copying all 135 newsletter posts from https://github.com/techworkersco/techworkersco.github.io here (hence large PR request) and fixing broken liquid inclusions.
Redirect previous blog posts on news.techworkerscoalition.org to internal /blog link structure. (done here) Redirects website to TWC unified blog techworkersco.github.io#456
Add blog cards at bottom of every blog to improve discoverability
Standardize icon/image sizes of press, blog and events
Pros