TrueType.php: Convert encoding of naming table strings#14
Merged
Conversation
The strings in the TTF name table are encoded differently depending on platformId and encodingId. Convert using mb_convert_encoding or iconv if those functions are available. Unicode uses UTF-16BE encoding for all strings, Macintosh encoding 0 uses MacRoman, and Windows uses UTF-16BE with 3 exceptions. Converting the encoding prevents gibberish when creating a font subset while maintaining Unicode and Windows UTF-16BE tables while dropping others.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14 +/- ##
============================================
- Coverage 86.82% 86.29% -0.54%
- Complexity 550 561 +11
============================================
Files 12 12
Lines 1822 1846 +24
============================================
+ Hits 1582 1593 +11
- Misses 240 253 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The strings in the TTF name table are encoded differently depending on platformId and encodingId. Convert using mb_convert_encoding or iconv if those functions are available.
Unicode uses UTF-16BE encoding for all strings, Macintosh encoding 0 uses MacRoman, and Windows uses UTF-16BE with 3 exceptions.
Converting the encoding prevents gibberish when creating a font subset while maintaining Unicode and Windows UTF-16BE tables while dropping others. Dropping the single License Description string in DejaVuSans-Bold saves around 74k when the string is encoded in UTF-16BE.
Noticed when using https://fontdrop.info/ comparing subset files generated with this package to those created via https://www.lddgo.net/en/convert/font-subset.