fix: joining uniform polygon border segments

Author: nicolaasuni

VERSION

@@ -1 +1 @@
-2.11.0
+2.12.0

src/Draw.php

@@ -351,6 +351,25 @@ public function getPolygon(array $points, string $mode = 'S', array $styles = []
             return $out;
         }
 
+        // When the outline is uniformly styled (no per-segment style overrides),
+        // stroke it as a single continuous path so that adjacent edges are joined
+        // at the vertices (miter/round/bevel) instead of being drawn as
+        // independent, butt-capped segments that would leave the corners open.
+        $hasSegmentStyles = false;
+        foreach ($styles as $skey => $sval) {
+            if (!\is_int($skey) || $sval === []) {
+                continue;
+            }
+
+            $hasSegmentStyles = true;
+            break;
+        }
+
+        if (!$hasSegmentStyles) {
+            $closed = $points[0] === ($points[$nco - 2] ?? null) && $points[1] === ($points[$nco - 1] ?? null);
+            return $out . $this->getBasicPolygon($points, $closed ? 's' : 'S');
+        }
+
         $nco -= 3;
 
         // paint the outline

test/DrawTest.php

@@ -493,16 +493,8 @@ public function testGetPolygon(): void
             . "\n"
             . '5.250000 66.750000 l'
             . "\n"
-            . 'S'
-            . "\n"
-            . '5.250000 66.750000 m'
-            . "\n"
             . '9.750000 62.250000 l'
             . "\n"
-            . 'S'
-            . "\n"
-            . '9.750000 62.250000 m'
-            . "\n"
             . '14.250000 57.750000 l'
             . "\n"
             . 'S'
@@ -576,7 +568,10 @@ public function testGetPolygon(): void
         );
 
         $res = $draw->getPolygon([0 => 3, 1 => 5, 2 => 7, 3 => 11, 4 => 13, 6 => 19, 7 => 23, 8 => 29]);
-        $this->assertEquals('2.250000 71.250000 m' . "\n" . '5.250000 66.750000 l' . "\n" . 'S' . "\n", $res);
+        $this->assertEquals(
+            '2.250000 71.250000 m' . "\n" . '5.250000 66.750000 l' . "\n" . '14.250000 57.750000 l' . "\n" . 'S' . "\n",
+            $res,
+        );
     }
 
     /**
@@ -595,22 +590,10 @@ public function testGetRegularPolygon(): void
             . "\n"
             . '7.460867 70.610186 l'
             . "\n"
-            . 'S'
-            . "\n"
-            . '7.460867 70.610186 m'
-            . "\n"
             . '4.468746 76.008116 l'
             . "\n"
-            . 'S'
-            . "\n"
-            . '4.468746 76.008116 m'
-            . "\n"
             . '-1.589607 74.830491 l'
             . "\n"
-            . 'S'
-            . "\n"
-            . '-1.589607 74.830491 m'
-            . "\n"
             . '-2.341753 68.704749 l'
             . "\n"
             . 'S'
@@ -744,58 +727,22 @@ public function testGetStarPolygon(): void
             . "\n"
             . '7.025568 69.069071 l'
             . "\n"
-            . 'S'
-            . "\n"
-            . '7.025568 69.069071 m'
-            . "\n"
             . '6.217685 74.688019 l'
             . "\n"
-            . 'S'
-            . "\n"
-            . '6.217685 74.688019 m'
-            . "\n"
             . '0.770904 76.287338 l'
             . "\n"
-            . 'S'
-            . "\n"
-            . '0.770904 76.287338 m'
-            . "\n"
             . '-2.946563 71.997153 l'
             . "\n"
-            . 'S'
-            . "\n"
-            . '-2.946563 71.997153 m'
-            . "\n"
             . '-0.588364 66.833419 l'
             . "\n"
-            . 'S'
-            . "\n"
-            . '-0.588364 66.833419 m'
-            . "\n"
             . '5.088364 66.833419 l'
             . "\n"
-            . 'S'
-            . "\n"
-            . '5.088364 66.833419 m'
-            . "\n"
             . '7.446563 71.997153 l'
             . "\n"
-            . 'S'
-            . "\n"
-            . '7.446563 71.997153 m'
-            . "\n"
             . '3.729096 76.287338 l'
             . "\n"
-            . 'S'
-            . "\n"
-            . '3.729096 76.287338 m'
-            . "\n"
             . '-1.717685 74.688019 l'
             . "\n"
-            . 'S'
-            . "\n"
-            . '-1.717685 74.688019 m'
-            . "\n"
             . '-2.525568 69.069071 l'
             . "\n"
             . 'S'
@@ -1012,25 +959,13 @@ public function testGetRect(): void
             . "\n"
             . '7.500000 71.250000 l'
             . "\n"
-            . 'S'
-            . "\n"
-            . '7.500000 71.250000 m'
-            . "\n"
             . '7.500000 63.000000 l'
             . "\n"
-            . 'S'
-            . "\n"
-            . '7.500000 63.000000 m'
-            . "\n"
             . '2.250000 63.000000 l'
             . "\n"
-            . 'S'
-            . "\n"
-            . '2.250000 63.000000 m'
-            . "\n"
             . '2.250000 71.250000 l'
             . "\n"
-            . 'S'
+            . 's'
             . "\n",
             $res,
         );