feat: Handle TiffImages.jl parameters.#70
Open
Klafyvel wants to merge 1 commit into
Open
Conversation
9664136 to
423b571
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related to #68. Patching TiffImages.jl to accept arbitrary IO subtype might be complex: they rely a lot on
seek, which is not compatible with the CodecZlib output I am targeting.An alternative is to decompress the file to disk and use a mmaped io, which is interesting anyway. So I modified the
tifftransformer so it becomes able to do that. A new difficulty is that although the tests seem to pass, I am not able to test it for a real case due to an error that I am struggling to understand.Given the following dataset:
I am getting this error:
ERROR: UnsatisfyableTransformer: There is no storage for "molecules" that can provide a Any. The defined storages are as follows: DataStorage{web}(IO) -> [IO, String, Vector{UInt8}, DataToolkitCore.FilePath, Any] Stacktrace: [1] read1(dataset::DataToolkitCore.DataSet, as::Type) @ DataToolkitCore ~/.julia/packages/DataToolkitCore/B5vZ5/src/interaction/externals.jl:220 [2] read(dataset::DataToolkitCore.DataSet, as::Type) @ DataToolkitCore ~/.julia/packages/DataToolkitCore/B5vZ5/src/interaction/externals.jl:151 [3] read(dataset::DataToolkitCore.DataSet) @ DataToolkitCore ~/.julia/packages/DataToolkitCore/B5vZ5/src/interaction/externals.jl:176 [4] macro expansion @ ~/.julia/packages/DataToolkitBase/iPXwX/src/DataToolkitBase.jl:23 [inlined] [5] top-level scope @ REPL[2]:1I still need to understand if I did something wrong in my patch or if that's a bug.