Skip to content

[WIP] WIP Address feedback from review on ListBox Parity Integration PR#164

Merged
tedd merged 1 commit into
forge-listbox-parity-5850515012165907113from
copilot/sub-pr-148-another-one
Mar 11, 2026
Merged

[WIP] WIP Address feedback from review on ListBox Parity Integration PR#164
tedd merged 1 commit into
forge-listbox-parity-5850515012165907113from
copilot/sub-pr-148-another-one

Conversation

Copilot AI commented Mar 11, 2026

Copy link
Copy Markdown
Contributor
  • Analyze the issue: ListBoxItem.UpdateVisualState sets Background/Foreground, but Control.Render only renders the template root without filling the background, so selected items show no highlight
  • Override Render in ListBoxItem to fill the full row with Background/Foreground before calling base.Render
  • Build and verify the change compiles
  • Run code review and security scan

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@tedd
tedd marked this pull request as ready for review March 11, 2026 13:17
Copilot AI review requested due to automatic review settings March 11, 2026 13:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tedd
tedd merged commit 3f5e8aa into forge-listbox-parity-5850515012165907113 Mar 11, 2026
1 of 2 checks passed
Copilot stopped work on behalf of tedd due to an error March 11, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants