Fix ListBoxItem visual state stuck when parent ListBox gains/loses focus#165
Merged
tedd merged 2 commits intoMar 11, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…focus Co-authored-by: tedd <493224+tedd@users.noreply.github.com>
tedd
merged commit Mar 11, 2026
b408a0c
into
forge-listbox-parity-5850515012165907113
1 check passed
Copilot
AI
changed the title
[WIP] WIP Address feedback on ListBox Parity Integration PR
Fix ListBoxItem visual state stuck when parent ListBox gains/loses focus
Mar 11, 2026
Copilot stopped work on behalf of
tedd due to an error
March 11, 2026 13:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ListBoxItem.UpdateVisualState()readsparentListBox.IsFocusedto pick focused vs. unfocused selection colors, but was only invoked onIsSelected/IsFocusedchanges on the item itself. When theListBoxgained or lost focus (e.g., Tab navigation) without any item property changing, colors would get stuck in the wrong state.Changes
ListBox— OverrideOnGotFocus()/OnLostFocus()to call a newNotifyContainersVisualStateChanged()helper that iteratesItemsPanelRoot.Childrenand refreshes eachListBoxItem's visual state immediately when the list box focus changes.ListBoxItem— WidenUpdateVisualState()fromprivatetointernalsoListBoxcan invoke it.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.