Fix ListBox coercing UIElement items to string when no ItemTemplate is set#167
Merged
tedd merged 2 commits intoMar 11, 2026
Merged
Conversation
…ForItemOverride Co-authored-by: tedd <493224+tedd@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on ListBox Parity Integration PR
Fix ListBox coercing UIElement items to string when no ItemTemplate is set
Mar 11, 2026
tedd
marked this pull request as ready for review
March 11, 2026 13:17
tedd
merged commit Mar 11, 2026
de772a8
into
forge-listbox-parity-5850515012165907113
3 checks passed
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes ListBox item hosting so that UIElement items (e.g., Button, TextBlock) are not coerced into strings when ItemTemplate is unset, preserving their rendering and interaction behavior within the ListBoxItem container model used for selection.
Changes:
- Update
ListBox.PrepareContainerForItemOverrideto detectUIElementitems and assign them directly toListBoxItem.ContentwhenItemTemplateisnull. - Keep existing behavior for non-
UIElementitems by continuing to fall back toGetItemText(item).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+111
to
+115
| else if (item is UIElement uiElement) | ||
| { | ||
| // Preserve UIElement items as content so they render and interact correctly | ||
| lbi.Content = uiElement; | ||
| } |
There was a problem hiding this comment.
Add unit coverage for the new UIElement-item branch (e.g., a TextBlock or Button in Items with ItemTemplate == null). Without a test, it’s easy to regress back to coercing UIElement items via GetItemText, since the existing ListBox render tests only cover string items and templated items.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ListBox.IsItemItsOwnContainerOverrideonly returnstrueforListBoxItem, so arbitraryUIElementitems (e.g.Button) are wrapped in a newListBoxItem. Previously,PrepareContainerForItemOverridealways calledGetItemText(item)whenItemTemplateis null, setting the container'sContentto a string and discarding the element entirely.Changes
ListBox.PrepareContainerForItemOverride: adds anelse if (item is UIElement)branch that assigns the element directly asContent, bypassingGetItemText. Non-UIElement items continue to fall back toGetItemText.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.