Fix trigger value lost when local override is cleared while trigger remains active#240
Merged
tedd merged 1 commit intoMar 25, 2026
Conversation
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on DependencyProperty/Trigger parity integration
Fix trigger value lost when local override is cleared while trigger remains active
Mar 25, 2026
tedd
marked this pull request as ready for review
March 25, 2026 17:52
tedd
merged commit Mar 25, 2026
3694600
into
forge/dependency-property-precedence-13154332135025318484
2 checks passed
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EvaluateTriggers()only fires when a condition property changes, so the re-apply path (wasActive && !HasLocalValue → shouldApplySetter = true) inControl.cswas never reached when a setter property was cleared — leaving the trigger value un-applied until the condition toggled.Changes
DependencyObject— layered value store_localOverridesActiveTrigger: HashSet<DependencyProperty>to track whenSetValueis called while a trigger is active_triggerValueswhen a local override is set (previously removed)GetValueprecedence: PostTriggerLocal (_localOverridesActiveTrigger+_localValues) → Trigger (_triggerValues) → PreTriggerLocal → Inherited → DefaultClearValueremoves the override flag; the trigger value surfaces automatically on the nextGetValue— noEvaluateTriggers()call neededClearTriggerValuecleans up the override flag when the trigger deactivatesControl— remove flawed re-apply pathwasActive && !target.HasLocalValue(...)re-apply block; the precedence model makes it unnecessaryTests
Trigger_ReExposesTriggerValue_AfterClearValueWhileActiveregression test covering the fullactivate → SetValue → ClearValue → deactivatecycle💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.