Skip to content

Commit 549836d

Browse files
dhensbyCopilot
andcommitted
amend! ci: disable fail-fast on test matrices
ci: disable fail-fast on the windows test matrix The test-windows job did not set fail-fast, so GitHub Actions defaulted to fail-fast: true. A single transient failure — often during the multi-minute SQL Server setup phase — cancelled every other in-progress and queued sibling job in the windows matrix. Those cancelled jobs would otherwise have passed, and re-running forced the entire expensive setup to be redone for all combinations. The test-linux matrix intentionally keeps fail-fast enabled: those jobs bootstrap much faster, and because test-windows needs test-linux, a linux failure should stop the run before the slower windows matrix starts rather than wasting time on it. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent ee9246d commit 549836d

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

.github/workflows/nodejs.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ jobs:
6666
env:
6767
MSSQL_PASSWORD: 'yourStrong(!)Password'
6868
strategy:
69-
fail-fast: false
7069
matrix:
7170
os: [ubuntu-24.04]
7271
node: [18.x, 20.x, 22.x, 24.x]

0 commit comments

Comments
 (0)