Skip to content

Commit ee9246d

Browse files
dhensbyCopilot
andcommitted
ci: disable fail-fast on test matrices
The test-linux and test-windows jobs did not set fail-fast, so GitHub Actions defaulted to fail-fast: true. A single transient failure — often during the multi-minute SQL Server setup phase — cancelled every other in-progress and queued sibling job in the matrix. Those cancelled jobs would otherwise have passed, and re-running forced the entire expensive setup to be redone for all combinations. Setting fail-fast: false on both matrices lets the rest of the matrix keep running when one combination fails. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent bcb8267 commit ee9246d

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

.github/workflows/nodejs.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,7 @@ jobs:
6666
env:
6767
MSSQL_PASSWORD: 'yourStrong(!)Password'
6868
strategy:
69+
fail-fast: false
6970
matrix:
7071
os: [ubuntu-24.04]
7172
node: [18.x, 20.x, 22.x, 24.x]
@@ -113,6 +114,7 @@ jobs:
113114
env:
114115
MSSQL_PASSWORD: 'yourStrong(!)Password'
115116
strategy:
117+
fail-fast: false
116118
matrix:
117119
os: [windows-2022, windows-2025]
118120
node: [18.x, 20.x, 22.x, 24.x]

0 commit comments

Comments
 (0)