Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -819,11 +819,20 @@ pool.close()
## Request

```javascript
const request = new sql.Request(/* [pool or transaction] */)
const request = new sql.Request(/* [pool or transaction], [options] */)
```

If you omit pool/transaction argument, global pool is used instead.

The optional `options` argument allows per-request configuration overrides:

- **requestTimeout** - Override the pool's default request timeout (in ms) for this request only.

```javascript
// Request with a 60-second timeout instead of the pool default
const request = new sql.Request(pool, { requestTimeout: 60000 })
```

### Events

- **recordset(columns)** - Dispatched when metadata for new recordset are parsed.
Expand Down Expand Up @@ -1144,11 +1153,13 @@ request.cancel()
**IMPORTANT:** always use `Transaction` class to create transactions - it ensures that all your requests are executed on one connection. Once you call `begin`, a single connection is acquired from the connection pool and all subsequent requests (initialized with the `Transaction` object) are executed exclusively on this connection. After you call `commit` or `rollback`, connection is then released back to the connection pool.

```javascript
const transaction = new sql.Transaction(/* [pool] */)
const transaction = new sql.Transaction(/* [pool], [options] */)
```

If you omit connection argument, global connection is used instead.

The optional `options` argument allows per-transaction configuration overrides (e.g. `{ requestTimeout: 60000 }`). These are inherited by any requests created from this transaction unless overridden at the request level. Note that the timeout applies to data requests only, not to the `begin`/`commit`/`rollback` operations themselves.

__Example__

```javascript
Expand Down Expand Up @@ -1296,11 +1307,13 @@ __Errors__
**IMPORTANT:** always use `PreparedStatement` class to create prepared statements - it ensures that all your executions of prepared statement are executed on one connection. Once you call `prepare`, a single connection is acquired from the connection pool and all subsequent executions are executed exclusively on this connection. After you call `unprepare`, the connection is then released back to the connection pool.

```javascript
const ps = new sql.PreparedStatement(/* [pool] */)
const ps = new sql.PreparedStatement(/* [pool], [options] */)
```

If you omit the connection argument, the global connection is used instead.

The optional `options` argument allows per-statement configuration overrides (e.g. `{ requestTimeout: 60000 }`). The timeout is applied to the `prepare`, `execute`, and `unprepare` operations.

__Example__

```javascript
Expand Down
10 changes: 6 additions & 4 deletions lib/base/connection-pool.js
Original file line number Diff line number Diff line change
Expand Up @@ -576,21 +576,23 @@ class ConnectionPool extends EventEmitter {
/**
* Returns new request using this connection.
*
* @param {{ requestTimeout?: number }} [conf] Per-request overrides.
* @return {Request}
*/

request () {
return new shared.driver.Request(this)
request (conf) {
return new shared.driver.Request(this, conf)
}

/**
* Returns new transaction using this connection.
*
* @param {{ requestTimeout?: number }} [conf] Per-transaction overrides, cascaded to child requests.
* @return {Transaction}
*/

transaction () {
return new shared.driver.Transaction(this)
transaction (conf) {
return new shared.driver.Transaction(this, conf)
Comment on lines 587 to +595
}

/**
Expand Down
15 changes: 10 additions & 5 deletions lib/base/prepared-statement.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,11 @@ class PreparedStatement extends EventEmitter {
/**
* Creates a new Prepared Statement.
*
* @param {ConnectionPool|Transaction} [holder]
* @param {ConnectionPool|Transaction} [parent]
* @param {{ requestTimeout?: number }} [overrides]
*/

constructor (parent) {
constructor (parent, overrides = {}) {
super()
Comment on lines +23 to 28

IDS.add(this, 'PreparedStatement')
Expand All @@ -33,6 +34,10 @@ class PreparedStatement extends EventEmitter {
this._handle = 0
this.prepared = false
this.parameters = {}
this.overrides = {}
if (Number.isFinite(overrides?.requestTimeout) && overrides.requestTimeout >= 0) {
this.overrides.requestTimeout = overrides.requestTimeout
}
}

get config () {
Expand Down Expand Up @@ -232,7 +237,7 @@ class PreparedStatement extends EventEmitter {
this._acquiredConnection = connection
this._acquiredConfig = config

const req = new shared.driver.Request(this)
const req = new shared.driver.Request(this, this.overrides)
req.stream = false
req.output('handle', TYPES.Int)
req.input('params', TYPES.NVarChar, ((() => {
Expand Down Expand Up @@ -294,7 +299,7 @@ class PreparedStatement extends EventEmitter {
*/

_execute (values, callback) {
const req = new shared.driver.Request(this)
const req = new shared.driver.Request(this, this.overrides)
req.stream = this.stream
req.arrayRowMode = this.arrayRowMode
req.input('handle', TYPES.Int, this._handle)
Expand Down Expand Up @@ -362,7 +367,7 @@ class PreparedStatement extends EventEmitter {
return setImmediate(callback, new TransactionError("Can't unprepare the statement. There is a request in progress.", 'EREQINPROG'))
}

const req = new shared.driver.Request(this)
const req = new shared.driver.Request(this, this.overrides)
req.stream = false
req.input('handle', TYPES.Int, this._handle)
req.execute('sp_unprepare', err => {
Expand Down
9 changes: 7 additions & 2 deletions lib/base/request.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,11 @@ class Request extends EventEmitter {
/**
* Create new Request.
*
* @param {Connection|ConnectionPool|Transaction|PreparedStatement} parent If omitted, global connection is used instead.
* @param {Connection|ConnectionPool|Transaction|PreparedStatement} [parent] If omitted, global connection is used instead.
* @param {{ requestTimeout?: number }} [overrides]
*/

constructor (parent) {
constructor (parent, overrides) {
super()

IDS.add(this, 'Request')
Expand All @@ -41,6 +42,10 @@ class Request extends EventEmitter {
this.parameters = {}
this.stream = null
this.arrayRowMode = null
this.overrides = {}
if (Number.isFinite(overrides?.requestTimeout) && overrides.requestTimeout >= 0) {
this.overrides.requestTimeout = overrides.requestTimeout
}
}

get paused () {
Expand Down
12 changes: 9 additions & 3 deletions lib/base/transaction.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,10 @@ class Transaction extends EventEmitter {
* Create new Transaction.
*
* @param {Connection} [parent] If ommited, global connection is used instead.
* @param {{ requestTimeout?: number }} [overrides]
*/

constructor (parent) {
constructor (parent, overrides = {}) {
super()

IDS.add(this, 'Transaction')
Expand All @@ -35,6 +36,10 @@ class Transaction extends EventEmitter {
this.parent = parent || globalConnection.pool
this.isolationLevel = Transaction.defaultIsolationLevel
this.name = ''
this.overrides = {}
if (Number.isFinite(overrides?.requestTimeout) && overrides.requestTimeout >= 0) {
this.overrides.requestTimeout = overrides.requestTimeout
}
}

get config () {
Expand Down Expand Up @@ -196,11 +201,12 @@ class Transaction extends EventEmitter {
/**
* Returns new request using this transaction.
*
* @param {{ requestTimeout?: number }} [config]
* @return {Request}
*/

request () {
return new shared.driver.Request(this)
request (config) {
return new shared.driver.Request(this, { ...this.overrides, ...config })
}
Comment on lines 202 to 210

/**
Expand Down
9 changes: 6 additions & 3 deletions lib/msnodesqlv8/request.js
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ class Request extends BaseRequest {
setImmediate(callback, new RequestError("You can't use table variables for bulk insert.", 'ENAME'))
}

this.parent.acquire(this, (err, connection) => {
this.parent.acquire(this, (err, connection, config) => {
let hasReturned = false
if (!err) {
debug('connection(%d): borrowed to request #%d', IDS.get(connection), IDS.get(this))
Expand Down Expand Up @@ -244,7 +244,10 @@ class Request extends BaseRequest {
objectid = table.path
}

return connection.queryRaw(`if object_id('${objectid.replace(/'/g, '\'\'')}') is null ${table.declare()}`, function (err) {
return connection.queryRaw({
query_str: `if object_id('${objectid.replace(/'/g, '\'\'')}') is null ${table.declare()}`,
query_timeout: (this.overrides.requestTimeout ?? config.requestTimeout) / 1000 // msnodesqlv8 timeouts are in seconds (<1 second not supported),
}, function (err) {
if (err) { return done(err) }
go()
})
Expand Down Expand Up @@ -389,7 +392,7 @@ class Request extends BaseRequest {

const req = connection.queryRaw({
query_str: command,
query_timeout: config.requestTimeout / 1000 // msnodesqlv8 timeouts are in seconds (<1 second not supported)
query_timeout: (this.overrides.requestTimeout ?? config.requestTimeout) / 1000 // msnodesqlv8 timeouts are in seconds (<1 second not supported)
}, params)

this._setCurrentRequest(req)
Expand Down
11 changes: 11 additions & 0 deletions lib/tedious/request.js
Original file line number Diff line number Diff line change
Expand Up @@ -361,6 +361,9 @@ class Request extends BaseRequest {

connection.execBulkLoad(bulk, table.rows)
})
if (typeof this.overrides.requestTimeout === 'number') {
req.setTimeout(this.overrides.requestTimeout)
}
this._setCurrentRequest(req)

connection.execSqlBatch(req)
Expand Down Expand Up @@ -510,6 +513,10 @@ class Request extends BaseRequest {
}
})

if (typeof this.overrides.requestTimeout === 'number') {
req.setTimeout(this.overrides.requestTimeout)
}

this._setCurrentRequest(req)

req.on('columnMetadata', metadata => {
Expand Down Expand Up @@ -859,6 +866,10 @@ class Request extends BaseRequest {
}
})

if (typeof this.overrides.requestTimeout === 'number') {
req.setTimeout(this.overrides.requestTimeout)
}

this._setCurrentRequest(req)

req.on('columnMetadata', metadata => {
Expand Down
4 changes: 2 additions & 2 deletions lib/tedious/transaction.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ const { IDS } = require('../utils')
const TransactionError = require('../error/transaction-error')

class Transaction extends BaseTransaction {
constructor (parent) {
super(parent)
constructor (parent, overrides) {
super(parent, overrides)

this._abort = () => {
if (!this._rollbackRequested) {
Expand Down
3 changes: 3 additions & 0 deletions test/cleanup.sql
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ if exists (select * from sys.procedures where name = '__testInputOutputValue')
if exists (select * from sys.procedures where name = '__testRowsAffected')
exec('drop procedure [dbo].[__testRowsAffected]')

if exists (select * from sys.procedures where name = '__testDelay')
exec('drop procedure [dbo].[__testDelay]')

if exists (select * from sys.types where is_user_defined = 1 and name = 'MSSQLTestType')
exec('drop type [dbo].[MSSQLTestType]')

Expand Down
102 changes: 102 additions & 0 deletions test/common/tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -1198,6 +1198,108 @@ module.exports = (sql, driver) => {
})
},

'per-request timeout overrides pool default' (done, driver, message) {
const config = readConfig()
config.driver = driver
config.requestTimeout = 15000

new sql.ConnectionPool(config).connect().then(conn => {
const req = new sql.Request(conn, { requestTimeout: 1000 })
req.query('waitfor delay \'00:00:05\';select 1').catch(err => {
assert.ok((message ? (message.exec(err.message) != null) : (err instanceof sql.RequestError)))

conn.close()
done()
})
}).catch(done)
},

'per-request timeout does not affect other requests' (done, driver, message) {
const config = readConfig()
config.driver = driver
config.requestTimeout = 15000

new sql.ConnectionPool(config).connect().then(conn => {
const reqFast = new sql.Request(conn, { requestTimeout: 1000 })
const reqNormal = new sql.Request(conn)

return Promise.allSettled([
reqFast.query('waitfor delay \'00:00:05\';select 1'),
reqNormal.query('waitfor delay \'00:00:02\';select 1')
]).then(([fastResult, normalResult]) => {
assert.strictEqual(fastResult.status, 'rejected')
assert.ok((message ? (message.exec(fastResult.reason.message) != null) : (fastResult.reason instanceof sql.RequestError)))
assert.strictEqual(normalResult.status, 'fulfilled')

conn.close()
done()
})
}).catch(done)
},

'per-request timeout in transaction' (done, driver, message) {
const config = readConfig()
config.driver = driver
config.requestTimeout = 15000

new sql.ConnectionPool(config).connect().then(conn => {
const tx = new sql.Transaction(conn, { requestTimeout: 1000 })
tx.begin().then(() => {
const req = tx.request()
req.query('waitfor delay \'00:00:05\';select 1').catch(err => {
assert.ok((message ? (message.exec(err.message) != null) : (err instanceof sql.RequestError)))

tx.rollback().then(() => {
conn.close()
done()
}).catch(() => {
conn.close()
done()
})
})
})
}).catch(done)
},

'per-request timeout on stored procedure' (done, driver, message) {
const config = readConfig()
config.driver = driver
config.requestTimeout = 15000

new sql.ConnectionPool(config).connect().then(conn => {
const req = new sql.Request(conn, { requestTimeout: 1000 })
req.execute('__testDelay').catch(err => {
assert.ok((message ? (message.exec(err.message) != null) : (err instanceof sql.RequestError)))

conn.close()
done()
})
}).catch(done)
},

'per-request timeout on prepared statement' (done, driver, message) {
const config = readConfig()
config.driver = driver
config.requestTimeout = 15000

new sql.ConnectionPool(config).connect().then(conn => {
const ps = new sql.PreparedStatement(conn, { requestTimeout: 1000 })
ps.prepare('waitfor delay \'00:00:05\';select 1').then(() => {
ps.execute().catch(err => {
assert.ok((message ? (message.exec(err.message) != null) : (err instanceof sql.RequestError)))

ps.unprepare().then(() => {
conn.close()
done()
}).catch(() => {
conn.close()
done()
})
})
})
}).catch(done)
},

'type validation' (mode, done) {
const req = new TestRequest()
req.input('image', sql.VarBinary, 'asdf')
Expand Down
Loading