Skip to content

Pass the CLI invocation to the runner#5017

Open
therazix wants to merge 1 commit into
mainfrom
fvagner-runner-cli
Open

Pass the CLI invocation to the runner#5017
therazix wants to merge 1 commit into
mainfrom
fvagner-runner-cli

Conversation

@therazix

Copy link
Copy Markdown
Contributor

The GuestLocal runner was created without a parent or cli_invocation, so CLI flags like --dry were always resolved to their defaults. Pass the run instance's CLI invocation explicitly so the runner inherits flags correctly.

Pull Request Checklist

  • implement the feature
  • write the documentation
  • extend the test coverage
  • update the specification
  • adjust plugin docstring
  • modify the json schema
  • mention the version
  • include a release note

@therazix therazix added the code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. label Jun 25, 2026
@therazix therazix added the review | trivial Very easy for review, even for beginners, so don't be afraid to have a look! :-) label Jun 25, 2026
@github-project-automation github-project-automation Bot moved this to backlog in planning Jun 25, 2026
@therazix therazix moved this from backlog to review in planning Jun 25, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request propagates the cli_invocation attribute from the current instance to the guest_runner object within the runner method of tmt/base/run.py. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@LecrisUT LecrisUT added the ci | full test Pull request is ready for the full test execution label Jul 7, 2026
@LecrisUT

LecrisUT commented Jul 7, 2026

Copy link
Copy Markdown
Member

Looking back on the discussion this one affects the LocalProvision dry mode. Think you can add a test to cover it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci | full test Pull request is ready for the full test execution code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. review | trivial Very easy for review, even for beginners, so don't be afraid to have a look! :-)

Projects

Status: review

Development

Successfully merging this pull request may close these issues.

2 participants