Move Environment class to its own module#5041
Merged
Merged
Conversation
happz
added
code | style
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Contributor
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
happz
force-pushed
the
move-environment
branch
2 times, most recently
from
July 3, 2026 18:30
9471635 to
7558dd6
Compare
LecrisUT
approved these changes
Jul 8, 2026
psss
reviewed
Jul 9, 2026
psss
left a comment
psss
left a comment
Member
There was a problem hiding this comment.
Looks good, just one leftover in tmt/convert.py:
1118: data['environment'] = tmt.utils.Environment.from_sequence(testcase.arguments, logger)
Contributor
Author
Addressed in 5af9841 |
Making `tmt.utils` smaller, but also part of the secrets implementation: by moving `Environment` and few other bits, it should be possible to close access to `os.environ`. A lot of changes, but just moves - some `tmt.utils.Environment` turned into `from tmt.utils.environment import Environment` + bare `Environment`; the string would have to change anyway, so at least we can treat `Environment` as a well-known name in the codebase. Related to #2609.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making
tmt.utilssmaller, but also part of the secrets implementation: by movingEnvironmentand few other bits, it should be possible to close access toos.environ.A lot of changes, but just moves - some
tmt.utils.Environmentturned intofrom tmt.utils.environment import Environment+ bareEnvironment; the string would have to change anyway, so at least we can treatEnvironmentas a well-known name in the codebase.Related to #2609.
Pull Request Checklist