Skip to content

Commit 918c8c2

Browse files
committed
Make PatchPoint(CalleeModifiedLocals) implicit
We don't have a good model for modeling weakref-like instruction dependency behavior and I don't think we should add it just for this.
1 parent 2471498 commit 918c8c2

2 files changed

Lines changed: 92 additions & 159 deletions

File tree

zjit/src/codegen.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -495,6 +495,8 @@ fn gen_send_without_block_direct(
495495
let branch = Branch::new();
496496
let dummy_ptr = cb.get_write_ptr().raw_ptr(cb);
497497
jit.branch_iseqs.push((branch.clone(), iseq));
498+
// TODO(max): Add a PatchPoint here that can side-exit the function if the callee messed with
499+
// the frame's locals
498500
Some(asm.ccall_with_branch(dummy_ptr, c_args, &branch))
499501
}
500502

0 commit comments

Comments
 (0)