Skip to content

Commit 7824cdc

Browse files
PuneetPunamiyaPuneetPunamiya
authored
Bumps sigstore to 1.8.15 and fixes unit tests (#1312)
Signed-off-by: PuneetPunamiya <ppunamiy@redhat.com>
1 parent 1ccf29b commit 7824cdc

16 files changed

Lines changed: 1195 additions & 17 deletions

File tree

‎go.mod‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ require (
2323
github.com/secure-systems-lab/go-securesystemslib v0.9.0
2424
github.com/sigstore/cosign/v2 v2.4.2
2525
github.com/sigstore/rekor v1.3.9
26-
github.com/sigstore/sigstore v1.8.12
26+
github.com/sigstore/sigstore v1.8.15
2727
github.com/sigstore/sigstore/pkg/signature/kms/aws v1.8.12
2828
github.com/sigstore/sigstore/pkg/signature/kms/azure v1.8.12
2929
github.com/sigstore/sigstore/pkg/signature/kms/gcp v1.8.12
@@ -440,7 +440,7 @@ require (
440440
golang.org/x/exp/typeparams v0.0.0-20241108190413-2d47ceb2692f // indirect
441441
golang.org/x/mod v0.22.0 // indirect
442442
golang.org/x/net v0.34.0 // indirect
443-
golang.org/x/oauth2 v0.25.0 // indirect
443+
golang.org/x/oauth2 v0.26.0 // indirect
444444
golang.org/x/sync v0.11.0 // indirect
445445
golang.org/x/sys v0.30.0 // indirect
446446
golang.org/x/term v0.29.0 // indirect

‎go.sum‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1225,8 +1225,8 @@ github.com/sigstore/protobuf-specs v0.4.0 h1:yoZbdh0kZYKOSiVbYyA8J3f2wLh5aUk2SQB
12251225
github.com/sigstore/protobuf-specs v0.4.0/go.mod h1:FKW5NYhnnFQ/Vb9RKtQk91iYd0MKJ9AxyqInEwU6+OI=
12261226
github.com/sigstore/rekor v1.3.9 h1:sUjRpKVh/hhgqGMs0t+TubgYsksArZ6poLEC3MsGAzU=
12271227
github.com/sigstore/rekor v1.3.9/go.mod h1:xThNUhm6eNEmkJ/SiU/FVU7pLY2f380fSDZFsdDWlcM=
1228-
github.com/sigstore/sigstore v1.8.12 h1:S8xMVZbE2z9ZBuQUEG737pxdLjnbOIcFi5v9UFfkJFc=
1229-
github.com/sigstore/sigstore v1.8.12/go.mod h1:+PYQAa8rfw0QdPpBcT+Gl3egKD9c+TUgAlF12H3Nmjo=
1228+
github.com/sigstore/sigstore v1.8.15 h1:9HHnZmxjPQSTPXTCZc25HDxxSTWwsGMh/ZhWZZ39maU=
1229+
github.com/sigstore/sigstore v1.8.15/go.mod h1:+Wa5mrG6A+Gss516YC9owy10q3IazqIRe0y1EoQRHHM=
12301230
github.com/sigstore/sigstore-go v0.7.0 h1:bIGPc2IbnbxnzlqQcKlh1o96bxVJ4yRElpP1gHrOH48=
12311231
github.com/sigstore/sigstore-go v0.7.0/go.mod h1:4RrCK+i+jhx7lyOG2Vgef0/kFLbKlDI1hrioUYvkxxA=
12321232
github.com/sigstore/sigstore/pkg/signature/kms/aws v1.8.12 h1:EC3UmIaa7nV9sCgSpVevmvgvTYTkMqyrRbj5ojPp7tE=
@@ -1648,8 +1648,8 @@ golang.org/x/oauth2 v0.0.0-20220309155454-6242fa91716a/go.mod h1:DAh4E804XQdzx2j
16481648
golang.org/x/oauth2 v0.0.0-20220411215720-9780585627b5/go.mod h1:DAh4E804XQdzx2j+YRIaUnCqCV2RuMz24cGBJ5QYIrc=
16491649
golang.org/x/oauth2 v0.0.0-20220608161450-d0670ef3b1eb/go.mod h1:jaDAt6Dkxork7LmZnYtzbRWj0W47D86a3TGe0YHBvmE=
16501650
golang.org/x/oauth2 v0.0.0-20220622183110-fd043fe589d2/go.mod h1:jaDAt6Dkxork7LmZnYtzbRWj0W47D86a3TGe0YHBvmE=
1651-
golang.org/x/oauth2 v0.25.0 h1:CY4y7XT9v0cRI9oupztF8AgiIu99L/ksR/Xp/6jrZ70=
1652-
golang.org/x/oauth2 v0.25.0/go.mod h1:XYTD2NtWslqkgxebSiOHnXEap4TF09sJSc7H1sXbhtI=
1651+
golang.org/x/oauth2 v0.26.0 h1:afQXWNNaeC4nvZ0Ed9XvCCzXM6UHJG7iCg0W4fPqSBE=
1652+
golang.org/x/oauth2 v0.26.0/go.mod h1:XYTD2NtWslqkgxebSiOHnXEap4TF09sJSc7H1sXbhtI=
16531653
golang.org/x/sync v0.0.0-20180314180146-1d60e4601c6f/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
16541654
golang.org/x/sync v0.0.0-20181108010431-42b317875d0f/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
16551655
golang.org/x/sync v0.0.0-20181221193216-37e7f081c4d4/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=

‎pkg/chains/signing/kms/kms_test.go‎

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -49,12 +49,13 @@ func TestInValidVaultAddressConnectionRefused(t *testing.T) {
4949
}
5050
}
5151

52+
var expectedErrorMessage = "no kms provider found for key reference: : parsing input key resource id: expected format: [plugin name]://[key ref], got: "
53+
5254
func TestValidVaultAddressConnectionWithoutPortAndScheme(t *testing.T) {
5355
cfg := config.KMSSigner{}
5456
cfg.Auth.Address = "abc.com"
5557

5658
_, err := NewSigner(context.Background(), cfg)
57-
expectedErrorMessage := "no kms provider found for key reference: "
5859
if err.Error() != expectedErrorMessage {
5960
t.Errorf("Expected error message '%s', but got '%s'", expectedErrorMessage, err.Error())
6061
}
@@ -65,7 +66,6 @@ func TestValidVaultAddressConnectionWithoutScheme(t *testing.T) {
6566
cfg.Auth.Address = "abc.com:80"
6667

6768
_, err := NewSigner(context.Background(), cfg)
68-
expectedErrorMessage := "no kms provider found for key reference: "
6969
if err.Error() != expectedErrorMessage {
7070
t.Errorf("Expected error message '%s', but got '%s'", expectedErrorMessage, err.Error())
7171
}
@@ -82,7 +82,6 @@ func TestValidVaultAddressConnection(t *testing.T) {
8282
cfg.Auth.Address = server.URL
8383

8484
_, err := NewSigner(context.Background(), cfg)
85-
expectedErrorMessage := "no kms provider found for key reference: "
8685
if err.Error() != expectedErrorMessage {
8786
t.Errorf("Expected error message '%s', but got '%s'", expectedErrorMessage, err.Error())
8887
}
@@ -98,7 +97,6 @@ func TestValidVaultAddressConnection(t *testing.T) {
9897
cfg.Auth.Address = server.URL
9998

10099
_, err := NewSigner(context.Background(), cfg)
101-
expectedErrorMessage := "no kms provider found for key reference: "
102100
if err.Error() != expectedErrorMessage {
103101
t.Errorf("Expected error message '%s', but got '%s'", expectedErrorMessage, err.Error())
104102
}
@@ -122,7 +120,6 @@ func TestValidVaultAddressConnection(t *testing.T) {
122120
cfg.Auth.Address = "http://127.0.0.1:41227"
123121

124122
_, err = NewSigner(context.Background(), cfg)
125-
expectedErrorMessage := "no kms provider found for key reference: "
126123
if err.Error() != expectedErrorMessage {
127124
t.Errorf("Expected error message '%s', but got '%s'", expectedErrorMessage, err.Error())
128125
}

‎vendor/github.com/sigstore/sigstore/pkg/signature/algorithm_registry.go‎

Lines changed: 206 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)