fix(deps): bump knative.dev/pkg to align OTel semconv versions#1802
Closed
infernus01 wants to merge 1 commit into
Closed
fix(deps): bump knative.dev/pkg to align OTel semconv versions#1802infernus01 wants to merge 1 commit into
infernus01 wants to merge 1 commit into
Conversation
The dependency bumps in this PR transitively require
go.opentelemetry.io/otel/sdk v1.44.0, which uses semconv/v1.41.0.
The previously vendored knative.dev/pkg (May 31 snapshot) uses
semconv/v1.40.0. At controller startup, knative's
observability/resource.Default() merges OTel resources with
conflicting schema URLs and panics:
panic: conflicting Schema URL:
https://opentelemetry.io/schemas/1.41.0
and https://opentelemetry.io/schemas/1.40.0
This crashes the controller (exit code 2, CrashLoopBackOff) and
fails all E2E tests.
Bump knative.dev/pkg to the June 22 snapshot which uses
semconv/v1.41.0, aligning both sides of the resource.Merge() call.
Signed-off-by: Shubham Bhardwaj <shubham.bhardwaj@outlook.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
tekton-robot
added
the
size/M
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes the E2E test failures in #1801.
The dependency bumps in #1801 transitively require
go.opentelemetry.io/otel/sdkv1.44.0, which usessemconv/v1.41.0.The previously vendored
knative.dev/pkg(May 31 snapshot) usessemconv/v1.40.0. At controller startup,knative.dev/pkg'sobservability/resource.Default()merges two OTel resources withconflicting schema URLs and panics:
This crashes the controller with exit code 2 (CrashLoopBackOff) before
any E2E test can run. Pinning
otel/sdkat v1.43.0 is not viablebecause both
cloud.google.com/go/storage@v1.63.0andgithub.com/sigstore/rekor@v1.5.3require v1.44.0.Fix: Bump
knative.dev/pkgfromv0.0.0-20260531000007(May 31)to
v0.0.0-20260622140654(June 22), which usessemconv/v1.41.0—matching the OTel SDK. Both sides of
resource.Merge()now agree onthe schema URL.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes