refactor: use slices.Contains to simplify code#1380
Conversation
Signed-off-by: jinjingroad <jinjingroad@sina.com>
The committers listed above are authorized under a signed CLA. |
|
Hi @jinjingroad. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lcarva, PuneetPunamiya The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
It seems there are some issues in |
Changes
In Go 1.21, the standard library includes built-in max/min function, which can greatly simplify the code.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes