Remove symlinks - due to ko-build update#1738
Conversation
|
also let's pin ko to 1.18.1 like it's done in tektoncd/pipeline#10358 also if necessary |
|
@waveywaves pinning versions is what I was trying to avoid.. isnt it a temporary solution well have to deal with anyway in the future? |
To me it sounds we need that temp solution until the ko fix is released and we can use that new ko binary. I see we use |
yes it was failing anyway witout it. pinned now |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enarha, waveywaves The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-v0.27.x |
|
/cherry-pick release-v0.26.x |
|
/cherry-pick release-v0.25.x |
|
✅ Cherry-pick to A new pull request has been created to cherry-pick this change to PR: #1744 Please review and merge the cherry-pick PR. |
|
✅ Cherry-pick to A new pull request has been created to cherry-pick this change to PR: #1745 Please review and merge the cherry-pick PR. |
|
✅ Cherry-pick to A new pull request has been created to cherry-pick this change to PR: #1746 Please review and merge the cherry-pick PR. |
Changes
Summary
kov0.19.1 introduced a security restriction that rejects symlinks in kodatathat resolve outside the kodata root directory. This broke all e2e tests in CI
since
setup-koinstalls the latest release.The
cmd/controller/kodata/directory contained symlinks to../../.git/HEADand
../../.git/refswhich are no longer used —knative.dev/pkg/changesetnow uses
debug.ReadBuildInfo()to get VCS info at runtime instead of readingfrom kodata.
Changes
cmd/controller/kodata/HEADsymlink (unused)cmd/controller/kodata/refssymlink (unused)cmd/controller/kodata/LICENSEsymlink with a real file copylogs from the failing tests:
2026-06-30T10:47:58.1714887Z Error: error processing import paths in "config/100-deployment.yaml": error resolving image references: tarring kodata: kodata symlink "/home/runner/work/chains/chains/cmd/controller/kodata/HEAD" resolves to "/home/runner/work/chains/chains/.git/HEAD" which is outside the kodata root "/home/runner/work/chains/chains/cmd/controller/kodata" 2026-06-30T10:47:58.1740223Z ERROR: Tekton Chains installation failed 2026-06-30T10:47:58.1742404Z *** E2E TEST FAILED ***Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes