Handle nil steps and add error message

divyansh42 · divyansh42 · commit 1fbbedb19a30 · 2025-08-19T17:54:10.000+05:30
Signed-off-by: divyansh42 &lt;diagrawa@redhat.com&gt;
diff --git a/pkg/log/task_reader.go b/pkg/log/task_reader.go
@@ -201,6 +201,10 @@ func (r *Reader) readPodLogs(podC <-chan string, podErrC <-chan error, follow, t
 				errC <- fmt.Errorf("task %s failed: %s. Run tkn tr desc %s for more details", r.task, strings.TrimSpace(err.Error()), r.run)
 			}
 			steps := filterSteps(pod, r.allSteps, r.steps)
+			if len(steps) == 0 {
+				errC <- fmt.Errorf("no steps found for task %s", r.task)
+				continue
+			}
 			r.readStepsLogs(logC, errC, steps, p, follow, timestamps)
 		}
 	}()
@@ -291,6 +295,7 @@ func (r *Reader) getTaskRunPodNames(run *v1.TaskRun) (<-chan string, <-chan erro
 func filterSteps(pod *corev1.Pod, allSteps bool, stepsGiven []string) []*step {
 	steps := []*step{}
 	if pod == nil {
+		fmt.Printf("pod not found")
 		return steps
 	}
 	stepsInPod := getSteps(pod)

Original file line number	Diff line number	Diff line change
`@@ -201,6 +201,10 @@ func (r *Reader) readPodLogs(podC <-chan string, podErrC <-chan error, follow, t`
`201`	`201`	`errC <- fmt.Errorf("task %s failed: %s. Run tkn tr desc %s for more details", r.task, strings.TrimSpace(err.Error()), r.run)`
`202`	`202`	`}`
`203`	`203`	`steps := filterSteps(pod, r.allSteps, r.steps)`
	`204`	`+ if len(steps) == 0 {`
	`205`	`+ errC <- fmt.Errorf("no steps found for task %s", r.task)`
	`206`	`+ continue`
	`207`	`+ }`
`204`	`208`	`r.readStepsLogs(logC, errC, steps, p, follow, timestamps)`
`205`	`209`	`}`
`206`	`210`	`}()`
`@@ -291,6 +295,7 @@ func (r Reader) getTaskRunPodNames(run v1.TaskRun) (<-chan string, <-chan erro`
`291`	`295`	`func filterSteps(pod corev1.Pod, allSteps bool, stepsGiven []string) []step {`
`292`	`296`	`steps := []*step{}`
`293`	`297`	`if pod == nil {`
	`298`	`+ fmt.Printf("pod not found")`
`294`	`299`	`return steps`
`295`	`300`	`}`
`296`	`301`	`stepsInPod := getSteps(pod)`