From a509aa30982dc9230c764defc447edfc45a558f0 Mon Sep 17 00:00:00 2001 From: huntlyroad <43883246+huntlyroad@users.noreply.github.com> Date: Thu, 10 Oct 2024 15:40:23 +0800 Subject: [PATCH 1/2] fix panic when trying to read pod logs when pod is already deleted --- pkg/log/task_reader.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pkg/log/task_reader.go b/pkg/log/task_reader.go index 7ba470bb2a..8abc7e5b8e 100644 --- a/pkg/log/task_reader.go +++ b/pkg/log/task_reader.go @@ -290,6 +290,9 @@ func (r *Reader) getTaskRunPodNames(run *v1.TaskRun) (<-chan string, <-chan erro func filterSteps(pod *corev1.Pod, allSteps bool, stepsGiven []string) []*step { steps := []*step{} + if pod == nil { + return steps + } stepsInPod := getSteps(pod) if allSteps { From c370dd60635466973fa151f0098c30793d594426 Mon Sep 17 00:00:00 2001 From: divyansh42 Date: Tue, 19 Aug 2025 17:54:10 +0530 Subject: [PATCH 2/2] Handle nil steps and add error message Signed-off-by: divyansh42 --- pkg/log/task_reader.go | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/pkg/log/task_reader.go b/pkg/log/task_reader.go index 8abc7e5b8e..766672b0a7 100644 --- a/pkg/log/task_reader.go +++ b/pkg/log/task_reader.go @@ -199,8 +199,13 @@ func (r *Reader) readPodLogs(podC <-chan string, podErrC <-chan error, follow, t } if err != nil { errC <- fmt.Errorf("task %s failed: %s. Run tkn tr desc %s for more details", r.task, strings.TrimSpace(err.Error()), r.run) + continue } steps := filterSteps(pod, r.allSteps, r.steps) + if len(steps) == 0 { + errC <- fmt.Errorf("no steps found for task %s", r.task) + continue + } r.readStepsLogs(logC, errC, steps, p, follow, timestamps) } }() @@ -291,6 +296,7 @@ func (r *Reader) getTaskRunPodNames(run *v1.TaskRun) (<-chan string, <-chan erro func filterSteps(pod *corev1.Pod, allSteps bool, stepsGiven []string) []*step { steps := []*step{} if pod == nil { + fmt.Printf("pod not found") return steps } stepsInPod := getSteps(pod)