Skip to content

fix panic when trying to read pod logs when pod is already deleted #2595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tekton-robot merged 2 commits into from
Aug 21, 2025
Merged

fix panic when trying to read pod logs when pod is already deleted #2595

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a509aa3
fix panic when trying to read pod logs when pod is already deleted
huntlyroad Oct 10, 2024
c370dd6
Handle nil steps and add error message
divyansh42 Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions pkg/log/task_reader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,8 +199,13 @@ func (r *Reader) readPodLogs(podC <-chan string, podErrC <-chan error, follow, t
}
if err != nil {
errC <- fmt.Errorf("task %s failed: %s. Run tkn tr desc %s for more details", r.task, strings.TrimSpace(err.Error()), r.run)
continue
}
steps := filterSteps(pod, r.allSteps, r.steps)
if len(steps) == 0 {
errC <- fmt.Errorf("no steps found for task %s", r.task)
continue
}
r.readStepsLogs(logC, errC, steps, p, follow, timestamps)
}
}()
Expand Down Expand Up @@ -290,6 +295,10 @@ func (r *Reader) getTaskRunPodNames(run *v1.TaskRun) (<-chan string, <-chan erro

func filterSteps(pod *corev1.Pod, allSteps bool, stepsGiven []string) []*step {
steps := []*step{}
if pod == nil {
fmt.Printf("pod not found")
return steps
}
stepsInPod := getSteps(pod)

if allSteps {
Expand Down
Loading