fix: update SendCloudEventsForRuns default and mark deprecated

Signed-off-by: Anitha Natarajan <anataraj@redhat.com>

Author: anithapriyanatarajan

pkg/apis/operator/v1alpha1/tektonpipeline_defaults.go

@@ -57,6 +57,8 @@ func (p *Pipeline) setDefaults() {
 		// EnableCustomTask is always enable
 		p.EnableCustomTasks = ptr.Bool(true)
 	}
+	// Deprecated: send-cloudevents-for-runs is deprecated upstream (pipeline v1.12.0).
+	// Default is now true. Will be removed in a future operator release.
 	if p.SendCloudEventsForRuns == nil {
 		p.SendCloudEventsForRuns = ptr.Bool(config.DefaultSendCloudEventsForRuns)
 	}

pkg/apis/operator/v1alpha1/tektonpipeline_defaults_test.go

@@ -50,19 +50,21 @@ func Test_SetDefaults_PipelineProperties(t *testing.T) {
 		EnableApiFields:                          "beta",
 		EmbeddedStatus:                           "",
 		ScopeWhenExpressionsToTask:               nil,
-		SendCloudEventsForRuns:                   ptr.Bool(false),
-		VerificationNoMatchPolicy:                config.DefaultNoMatchPolicyConfig,
-		EnableProvenanceInStatus:                 ptr.Bool(true),
-		EnforceNonfalsifiability:                 config.DefaultEnforceNonfalsifiability,
-		EnableKeepPodOnCancel:                    ptr.Bool(config.DefaultEnableKeepPodOnCancel.Enabled),
-		ResultExtractionMethod:                   config.DefaultResultExtractionMethod,
-		MaxResultSize:                            ptr.Int32(config.DefaultMaxResultSize),
-		SetSecurityContext:                       ptr.Bool(config.DefaultSetSecurityContext),
-		Coschedule:                               config.DefaultCoschedule,
-		DisableInlineSpec:                        config.DefaultDisableInlineSpec,
-		EnableCELInWhenExpression:                ptr.Bool(config.DefaultEnableCELInWhenExpression.Enabled),
-		EnableStepActions:                        ptr.Bool(config.DefaultFeatureFlags.EnableStepActions),
-		EnableParamEnum:                          ptr.Bool(config.DefaultEnableParamEnum.Enabled),
+		// Deprecated: default changed from false to true in tektoncd/pipeline v1.12.0
+		// (https://github.com/tektoncd/pipeline/pull/9774)
+		SendCloudEventsForRuns:    ptr.Bool(true),
+		VerificationNoMatchPolicy: config.DefaultNoMatchPolicyConfig,
+		EnableProvenanceInStatus:  ptr.Bool(true),
+		EnforceNonfalsifiability:  config.DefaultEnforceNonfalsifiability,
+		EnableKeepPodOnCancel:     ptr.Bool(config.DefaultEnableKeepPodOnCancel.Enabled),
+		ResultExtractionMethod:    config.DefaultResultExtractionMethod,
+		MaxResultSize:             ptr.Int32(config.DefaultMaxResultSize),
+		SetSecurityContext:        ptr.Bool(config.DefaultSetSecurityContext),
+		Coschedule:                config.DefaultCoschedule,
+		DisableInlineSpec:         config.DefaultDisableInlineSpec,
+		EnableCELInWhenExpression: ptr.Bool(config.DefaultEnableCELInWhenExpression.Enabled),
+		EnableStepActions:         ptr.Bool(config.DefaultFeatureFlags.EnableStepActions),
+		EnableParamEnum:           ptr.Bool(config.DefaultEnableParamEnum.Enabled),
 		PipelineMetricsProperties: PipelineMetricsProperties{
 			MetricsPipelinerunDurationType: "histogram",
 			MetricsPipelinerunLevel:        "pipeline",

pkg/apis/operator/v1alpha1/tektonpipeline_types.go

@@ -102,7 +102,13 @@ type PipelineProperties struct {
 	EnableCustomTasks                        *bool  `json:"enable-custom-tasks,omitempty"`
 	EnableApiFields                          string `json:"enable-api-fields,omitempty"`
 	EmbeddedStatus                           string `json:"embedded-status,omitempty"`
-	SendCloudEventsForRuns                   *bool  `json:"send-cloudevents-for-runs,omitempty"`
+	// Deprecated: send-cloudevents-for-runs is deprecated in tektoncd/pipeline v1.12.0
+	// (https://github.com/tektoncd/pipeline/pull/9774) and will be removed in a future release.
+	// CloudEvents for CustomRuns are now enabled by default when a sink is configured in
+	// the config-events ConfigMap. This field only affects CustomRun objects; it has no
+	// effect on TaskRuns or PipelineRuns. Set to false only to suppress duplicate events
+	// when a custom task controller already sends its own CloudEvents.
+	SendCloudEventsForRuns *bool `json:"send-cloudevents-for-runs,omitempty"`
 	// "verification-mode" is deprecated and never used.
 	// This field will be removed, see https://github.com/tektoncd/operator/issues/1497
 	// originally this field was removed in https://github.com/tektoncd/operator/pull/1481