fix(SRVKP-11820): align lint with CI and drop unused consts

Fix two issues found during agentic workflow setup:

- Makefile: add version check so local golangci-lint binary is
  reinstalled when it diverges from the version in ci.yaml
  (v2.7.2); add PKG variable to lint-go for fast single-package
  iteration
- Remove unused resourceKind constants in tektonchain,
  tektonpipeline, and tektontrigger reconcilers that caused
  lint failures locally

Signed-off-by: Jawed khelil <jkhelil@redhat.com>
Assisted-by: Claude Sonnet 4.6 (via Cursor)
Co-authored-by: Cursor <cursoragent@cursor.com>

Author: jkhelil

Makefile

@@ -44,7 +44,11 @@ $(BIN)/kustomize: | $(BIN) ; $(info $(M) getting kustomize)
 
 GOLANGCILINT = $(or ${GOLANGCILINT_BIN},${GOLANGCILINT_BIN},$(BIN)/golangci-lint)
 $(BIN)/golangci-lint: | $(BIN) ; $(info $(M) getting golangci-lint $(GOLANGCI_VERSION))
-	@curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(BIN) $(GOLANGCI_VERSION)
+	@if [ -f $(BIN)/golangci-lint ] && $(BIN)/golangci-lint --version 2>/dev/null | grep -qF "$(GOLANGCI_VERSION)"; then \
+		echo "golangci-lint $(GOLANGCI_VERSION) already installed"; \
+	else \
+		curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(BIN) $(GOLANGCI_VERSION); \
+	fi
 
 ##@ Clean 
 .PHONY: clean-cluster
@@ -192,13 +196,14 @@ test-unit: ## Run unit tests
 .PHONY: lint
 lint: lint-go lint-yaml ## run all linters
 
+PKG ?= ./...
 .PHONY: lint-go
-lint-go: | $(GOLANGCILINT) ## runs go linter on all go files
+lint-go: | $(GOLANGCILINT) ## runs go linter; set PKG=./some/pkg/... to lint a single package
 	@echo "Linting go files..."
-	@$(GOLANGCILINT) run ./... --modules-download-mode=vendor \
-							--max-issues-per-linter=0 \
-							--max-same-issues=0 \
-							--timeout 5m
+	@$(GOLANGCILINT) run $(PKG) --modules-download-mode=vendor \
+						--max-issues-per-linter=0 \
+						--max-same-issues=0 \
+						--timeout 5m
 
 YAML_FILES := $(shell find . -type f -regex ".*y[a]ml" -print)
 .PHONY: lint-yaml

pkg/reconciler/kubernetes/tektonchain/tektonchain.go

@@ -46,8 +46,6 @@ import (
 )
 
 const (
-	resourceKind = v1alpha1.KindTektonChain
-
 	// Chains ConfigMap
 	ChainsConfig = "chains-config"
 	// Chains Container Name

pkg/reconciler/kubernetes/tektonpipeline/reconcile.go

@@ -32,8 +32,6 @@ import (
 )
 
 const (
-	resourceKind = v1alpha1.KindTektonPipeline
-
 	proxyLabel = "operator.tekton.dev/disable-proxy=true"
 )
 

pkg/reconciler/kubernetes/tektontrigger/reconcile.go

@@ -34,8 +34,6 @@ import (
 	pkgreconciler "knative.dev/pkg/reconciler"
 )
 
-const resourceKind = v1alpha1.KindTektonTrigger
-
 // Reconciler implements controller.Reconciler for TektonTrigger resources.
 type Reconciler struct {
 	// kube client to interact with core k8s resources