Skip to content

Commit a4e8dba

Browse files
anithapriyanatarajantekton-robot
authored andcommitted
chore: fix failing unit tests during upgrade
Signed-off-by: Anitha Natarajan <anataraj@redhat.com>
1 parent d42a211 commit a4e8dba

2 files changed

Lines changed: 14 additions & 0 deletions

File tree

pkg/apis/operator/v1alpha1/openshiftpipelinesascode_defaults_test.go

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,9 @@ func TestSetPACControllerDefaultSettings(t *testing.T) {
7171
"secret-github-app-scope-extra-repos": "",
7272
"secret-github-app-token-scoped": "true",
7373
"tekton-dashboard-url": "",
74+
"tracing-label-action": "",
75+
"tracing-label-application": "",
76+
"tracing-label-component": "",
7477
}
7578

7679
assert.DeepEqual(t, opacCR.Spec.PACSettings.Settings, expectedSettings)
@@ -130,6 +133,9 @@ func TestSetPACControllerLimitedSettings(t *testing.T) {
130133
"secret-github-app-scope-extra-repos": "",
131134
"secret-github-app-token-scoped": "true",
132135
"tekton-dashboard-url": "",
136+
"tracing-label-action": "",
137+
"tracing-label-application": "",
138+
"tracing-label-component": "",
133139
}
134140

135141
assert.DeepEqual(t, opacCR.Spec.PACSettings.Settings, expectedSettings)
@@ -196,6 +202,9 @@ func TestSetPACControllerDefaultSettingsWithMultipleCatalogs(t *testing.T) {
196202
"secret-github-app-scope-extra-repos": "",
197203
"secret-github-app-token-scoped": "true",
198204
"tekton-dashboard-url": "",
205+
"tracing-label-action": "",
206+
"tracing-label-application": "",
207+
"tracing-label-component": "",
199208
}
200209

201210
assert.DeepEqual(t, opacCR.Spec.PACSettings.Settings, expectedSettings)

pkg/reconciler/openshift/openshiftpipelinesascode/testdata/test-expected-additional-pac-cm.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -156,6 +156,11 @@ data:
156156
custom-console-url-pr-details: ""
157157
custom-console-url-pr-tasklog: ""
158158

159+
# Tracing label names used for distributed tracing of webhook handling and PipelineRun timing.
160+
tracing-label-action: ""
161+
tracing-label-application: ""
162+
tracing-label-component: ""
163+
159164
kind: ConfigMap
160165
metadata:
161166
name: test-config

0 commit comments

Comments
 (0)