Skip to content

fix(networkpolicy): allow all egress for API server access#3755

Open
khrm wants to merge 1 commit into
tektoncd:mainfrom
khrm:fix/networkpolicy-apiserver-egress
Open

fix(networkpolicy): allow all egress for API server access#3755
khrm wants to merge 1 commit into
tektoncd:mainfrom
khrm:fix/networkpolicy-apiserver-egress

Conversation

@khrm

@khrm khrm commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

NetworkPolicy cannot select host-network endpoints, and the API server port is configurable (SDN sometime have different port), so allow unrestricted egress. Remove APIServerPort from PlatformParams. Admin network policy could improve this later but would break third-party SDNs.

Assisted-by: Claude Opus 4.6 (1M context) noreply@anthropic.com

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Jul 17, 2026
@tekton-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from khrm after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 17, 2026
@codecov-commenter

codecov-commenter commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 25.47%. Comparing base (dd17bc5) to head (db76d53).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3755      +/-   ##
==========================================
- Coverage   25.49%   25.47%   -0.03%     
==========================================
  Files         449      449              
  Lines       23370    23363       -7     
==========================================
- Hits         5959     5952       -7     
  Misses      16725    16725              
  Partials      686      686              
Flag Coverage Δ
unit-tests 25.47% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

NetworkPolicy cannot select host-network endpoints and the API server
port is configurable, so allow unrestricted egress. Remove APIServerPort
from PlatformParams. Admin network policy could improve this later but
would break third-party SDNs.

Signed-off-by: Khurram Baig <kbaig@redhat.com>
Assisted-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@khrm
khrm force-pushed the fix/networkpolicy-apiserver-egress branch from ef6c3df to db76d53 Compare July 17, 2026 10:29
@jkhelil

jkhelil commented Jul 17, 2026

Copy link
Copy Markdown
Member

@khrm can you update. the doc under docs/networkpolicy.md

@jkhelil jkhelil left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the doc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants