Skip to content

fix: update SendCloudEventsForRuns default and mark deprecated#3430

Merged
tekton-robot merged 1 commit into
tektoncd:dependabot/go_modules/github.com/tektoncd/pipeline-1.12.0from
anithapriyanatarajan:fix-version
May 19, 2026
Merged

fix: update SendCloudEventsForRuns default and mark deprecated#3430
tekton-robot merged 1 commit into
tektoncd:dependabot/go_modules/github.com/tektoncd/pipeline-1.12.0from
anithapriyanatarajan:fix-version

Conversation

@anithapriyanatarajan

@anithapriyanatarajan anithapriyanatarajan commented May 18, 2026

Copy link
Copy Markdown
Contributor

Changes

This PR fixes test failure due to tektoncd/pipeline v1.12.0

(tektoncd/pipeline#9774) deprecated the
send-cloudevents-for-runs feature flag and changed its default from false to true. CloudEvents for CustomRuns are now enabled by default when a sink is configured in config-events.

  • Add deprecation comments to PipelineProperties field and SetDefaults
  • Fix test expectation: false -> true to match new upstream default

Ref: tektoncd/pipeline#9774

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

`send-cloudevents-for-runs` default changed from `false` to `true` to align with
tektoncd/pipeline v1.12.0 (upstream deprecation). The `SendCloudEventsForRuns` field
in `TektonPipeline` spec is now deprecated and will be removed in a future release
IssueRef: https://github.com/tektoncd/operator/issues/3439

Signed-off-by: Anitha Natarajan <anataraj@redhat.com>
@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label May 18, 2026
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 18, 2026
@anithapriyanatarajan

Copy link
Copy Markdown
Contributor Author

/kind bug

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label May 18, 2026
@anithapriyanatarajan

anithapriyanatarajan commented May 18, 2026

Copy link
Copy Markdown
Contributor Author

@vdemeester @jkhelil - This PR fixes the ci failures of #3418

@jkhelil

jkhelil commented May 19, 2026

Copy link
Copy Markdown
Member

thank you @anithapriyanatarajan , can you please

  • add a tracking issue for removal and add it to the comment
  • Add release note, eventually documentation

@tekton-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2026
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesnt merit a release note. labels May 19, 2026
@anithapriyanatarajan

Copy link
Copy Markdown
Contributor Author

thank you @anithapriyanatarajan , can you please

  • add a tracking issue for removal and add it to the comment
  • Add release note, eventually documentation

@jkhelil Issue for tracking - #3430
Added a release note to this PR.

@jkhelil

jkhelil commented May 19, 2026

Copy link
Copy Markdown
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2026
@tekton-robot tekton-robot merged commit 487a5ea into tektoncd:dependabot/go_modules/github.com/tektoncd/pipeline-1.12.0 May 19, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants