fix(common): apply proxy settings to StatefulSets too

[jkhelil]

Changes

ApplyProxySettings only handled resources of kind Deployment, so when
spec.pipeline.performance.statefulset-ordinals is enabled in TektonConfig
and the tekton-pipelines-controller / tekton-pipelines-remote-resolvers
Deployments are converted into StatefulSets, the resulting StatefulSet pods
never inherited the cluster-wide proxy environment variables (HTTP_PROXY,
HTTPS_PROXY, NO_PROXY) that Deployment-based pods correctly pick up.

This PR:

• Extends ApplyProxySettings to also process StatefulSet resources
  (it's already invoked for both kinds from tektoninstallerset ensureResource,
  but silently no-op'd for StatefulSets).
• Hardens the containers lookup so a present-but-null containers field
  (e.g. an empty/placeholder StatefulSet) is treated as "no containers"
  instead of returning a type-mismatch error.
• Adds unit tests covering StatefulSet proxy injection/removal and confirms
  other resource kinds remain unaffected.

Fixes: https://redhat.atlassian.net/browse/SRVKP-12831

Submitter Checklist

• Run make test lint before submitting a PR
• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices

Release Notes

Fix StatefulSet pods (used when `statefulset-ordinals` is enabled) not
inheriting cluster-wide proxy environment variables.

Made with Cursor

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 25.52%. Comparing base (9f33b03) to head (6f25544).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3710   +/-   ##
=======================================
  Coverage   25.51%   25.52%           
=======================================
  Files         448      448           
  Lines       23309    23309           
=======================================
+ Hits         5948     5950    +2     
+ Misses      16675    16674    -1     
+ Partials      686      685    -1     

Flag	Coverage Δ
unit-tests	25.52% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[pratap0007]

/lgtm

[jkhelil]

/kind Bug

[l-qing]

Thanks for this fix @jkhelil. All checks are green and it already has a /lgtm, but tide is blocking the merge with Not mergeable. PR can't be rebased — the branch has drifted from main and Prow can't auto-rebase it.

Could you rebase fix/statefulset-proxy-settings-SRVKP-12831 onto the latest main and force-push? That should clear the tide block and let it merge. Thanks!

[jkhelil]

/approve

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkhelil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [jkhelil]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jkhelil]

/cherry-pick release-v0.80.x

[jkhelil]

/cherry-pick release-v0.79.x

[tekton-robot]

✅ Cherry-pick to release-v0.80.x successful!

A new pull request has been created to cherry-pick this change to release-v0.80.x.

PR: #3737

Please review and merge the cherry-pick PR.

[tekton-robot]

✅ Cherry-pick to release-v0.79.x successful!

A new pull request has been created to cherry-pick this change to release-v0.79.x.

PR: #3738

Please review and merge the cherry-pick PR.