[cherry-pick: release-v0.79.x] fix(common): apply proxy settings to StatefulSets too#3738
Merged
tekton-robot merged 2 commits intoJul 15, 2026
Merged
Conversation
ApplyProxySettings only handled Deployment resources, so pods running as StatefulSets (e.g. when statefulset-ordinals is enabled) never inherited the cluster-wide proxy environment variables. Extend the transformer to also cover the StatefulSet kind, and harden the containers lookup to tolerate a null containers field instead of erroring out. Fixes SRVKP-12831 Signed-off-by: Jawed khelil <jkhelil@redhat.com> Assisted-by: Claude Sonnet 5 (via Cursor) Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
tekton-robot
added
the
release-note
tekton-robot
added
the
size/L
Contributor
|
/lgtm |
Contributor
|
/lgtm |
Member
|
/approve |
Contributor
Author
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jkhelil, pratap0007 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick of #3710
Changes
ApplyProxySettingsonly handled resources of kindDeployment, so whenspec.pipeline.performance.statefulset-ordinalsis enabled inTektonConfigand the
tekton-pipelines-controller/tekton-pipelines-remote-resolversDeployments are converted into StatefulSets, the resulting StatefulSet pods
never inherited the cluster-wide proxy environment variables (
HTTP_PROXY,HTTPS_PROXY,NO_PROXY) that Deployment-based pods correctly pick up.This PR:
ApplyProxySettingsto also processStatefulSetresources(it's already invoked for both kinds from
tektoninstallersetensureResource,but silently no-op'd for StatefulSets).
nullcontainersfield(e.g. an empty/placeholder StatefulSet) is treated as "no containers"
instead of returning a type-mismatch error.
other resource kinds remain unaffected.
Fixes: https://redhat.atlassian.net/browse/SRVKP-12831
Submitter Checklist
make test lintbefore submitting a PRRelease Notes
Made with Cursor