Hub template removal #3740
Conversation
… to generated files
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3740 +/- ##
=======================================
Coverage 25.55% 25.55%
=======================================
Files 448 448
Lines 23317 23317
=======================================
Hits 5958 5958
Misses 16674 16674
Partials 685 685
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| - Tekton Chains: {{ with index .Versions "chains"}}{{ .Version }}{{end}} | ||
| - Tekton Hub (tech-preview): {{ with index .Versions "hub"}}{{ .Version }}{{end}} | ||
| - Tekton Results: {{ with index .Versions "results"}}{{ .Version }}{{end}} | ||
| - Tekton Results (tech-preview): {{ with index .Versions "results"}}{{ .Version }}{{end}} |
There was a problem hiding this comment.
| - Tekton Results (tech-preview): {{ with index .Versions "results"}}{{ .Version }}{{end}} | |
| - Tekton Results: {{ with index .Versions "results"}}{{ .Version }}{{end}} |
Changes
Follow-up to #3494. The CSV template source files (
.tmpl) still containedhardcoded TektonHub references. When the bump automation ran and regenerated
the CSV output files from these templates, hub entries were re-introduced
(see #3715).
Removed TektonHub owned-CRD entries, internal-objects annotation reference,
and version line from both OperatorHub CSV templates.
**Bump itself is not happening, since the bump script iterates
components.yamlof which hub is already removed.You can see in Makefile:
COMPONENT ?= components.yamland then
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make test lintbefore submitting a PRSee the contribution guide for more details.
Release Notes