Skip to content

Hub template removal #3740

Open
ngelman1 wants to merge 1 commit into
tektoncd:mainfrom
ngelman1:remove-hub-from-tmp
Open

Hub template removal #3740
ngelman1 wants to merge 1 commit into
tektoncd:mainfrom
ngelman1:remove-hub-from-tmp

Conversation

@ngelman1

Copy link
Copy Markdown
Contributor

Changes

Follow-up to #3494. The CSV template source files (.tmpl) still contained
hardcoded TektonHub references. When the bump automation ran and regenerated
the CSV output files from these templates, hub entries were re-introduced
(see #3715).
Removed TektonHub owned-CRD entries, internal-objects annotation reference,
and version line from both OperatorHub CSV templates.

**Bump itself is not happening, since the bump script iterates components.yaml of which hub is already removed.
You can see in Makefile:
COMPONENT ?= components.yaml

and then

##@ Bump Components Version

.PHONY: components/bump  
components/bump: $(OPERATORTOOL) ## Bump the version of a component 
	@go run ./cmd/tool bump ${COMPONENT}

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Jul 15, 2026
@tekton-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign enarha after the PR has been reviewed.
You can assign the PR to them by writing /assign @enarha in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 15, 2026
@ngelman1 ngelman1 changed the title remove hub from the template source file so that hub wont be re-added… Hub template removal Jul 15, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 25.55%. Comparing base (4300f2e) to head (7211a32).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3740   +/-   ##
=======================================
  Coverage   25.55%   25.55%           
=======================================
  Files         448      448           
  Lines       23317    23317           
=======================================
  Hits         5958     5958           
  Misses      16674    16674           
  Partials      685      685           
Flag Coverage Δ
unit-tests 25.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@infernus01 infernus01 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor correction

- Tekton Chains: {{ with index .Versions "chains"}}{{ .Version }}{{end}}
- Tekton Hub (tech-preview): {{ with index .Versions "hub"}}{{ .Version }}{{end}}
- Tekton Results: {{ with index .Versions "results"}}{{ .Version }}{{end}}
- Tekton Results (tech-preview): {{ with index .Versions "results"}}{{ .Version }}{{end}}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Tekton Results (tech-preview): {{ with index .Versions "results"}}{{ .Version }}{{end}}
- Tekton Results: {{ with index .Versions "results"}}{{ .Version }}{{end}}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants