Skip to content

Hub template removal #3740

Open
ngelman1 wants to merge 1 commit into
tektoncd:mainfrom
ngelman1:remove-hub-from-tmp
Open

Hub template removal #3740
ngelman1 wants to merge 1 commit into
tektoncd:mainfrom
ngelman1:remove-hub-from-tmp

Conversation

@ngelman1

@ngelman1 ngelman1 commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Changes

Follow-up to #3494. The CSV template source files (.tmpl) still contained
hardcoded TektonHub references. When the bump automation ran and regenerated
the CSV output files from these templates, hub entries were re-introduced
(see #3715).
Removed TektonHub owned-CRD entries, internal-objects annotation reference,
and version line from both OperatorHub CSV templates.

**Bump itself is not happening, since the bump script iterates components.yaml of which hub is already removed.
You can see in Makefile:
COMPONENT ?= components.yaml

and then

##@ Bump Components Version

.PHONY: components/bump  
components/bump: $(OPERATORTOOL) ## Bump the version of a component 
	@go run ./cmd/tool bump ${COMPONENT}

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Jul 15, 2026
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 15, 2026
@ngelman1 ngelman1 changed the title remove hub from the template source file so that hub wont be re-added… Hub template removal Jul 15, 2026
@codecov-commenter

codecov-commenter commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 25.55%. Comparing base (4300f2e) to head (7211a32).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3740   +/-   ##
=======================================
  Coverage   25.55%   25.55%           
=======================================
  Files         448      448           
  Lines       23317    23317           
=======================================
  Hits         5958     5958           
  Misses      16674    16674           
  Partials      685      685
Flag Coverage Δ
unit-tests 25.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

infernus01
infernus01 suggested changes Jul 15, 2026
View reviewed changes

@infernus01 infernus01 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor correction

Comment thread ...ift/manifests/bases/openshift-pipelines-operator-rh.clusterserviceversion.template.yaml.tmpl
- Tekton Chains: {{ with index .Versions "chains"}}{{ .Version }}{{end}}
- Tekton Hub (tech-preview): {{ with index .Versions "hub"}}{{ .Version }}{{end}}
- Tekton Results: {{ with index .Versions "results"}}{{ .Version }}{{end}}
- Tekton Results (tech-preview): {{ with index .Versions "results"}}{{ .Version }}{{end}}

@infernus01 infernus01 Jul 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Tekton Results (tech-preview): {{ with index .Versions "results"}}{{ .Version }}{{end}}
- Tekton Results: {{ with index .Versions "results"}}{{ .Version }}{{end}}

@pratap0007 pratap0007 Jul 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already fixed. I think the branch hasn't been rebased with the main branch.

@pratap0007

pratap0007 commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

/approve

@tekton-robot

tekton-robot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pratap0007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2026
@jkhelil

jkhelil commented Jul 16, 2026

Copy link
Copy Markdown
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pratap0007 pratap0007 Awaiting requested review from pratap0007
1 more reviewer
@infernus01 infernus01 infernus01 requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

@jkhelil jkhelil

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ngelman1 @codecov-commenter @pratap0007 @tekton-robot @jkhelil @infernus01