fix: remove unneeded check

filariow · zakisk · commit a43ae55e36e2 · 2026-05-14T16:20:09.000+05:30
Signed-off-by: Francesco Ilario &lt;filario@redhat.com&gt;

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
diff --git a/pkg/formatting/k8labels.go b/pkg/formatting/k8labels.go
@@ -3,7 +3,6 @@ package formatting
 import (
 	"slices"
 	"strings"
-	"unicode"
 
 	"k8s.io/apimachinery/pkg/util/validation"
 )
@@ -84,8 +83,7 @@ func pairs(m map[rune]string) []string {
 
 // isSafe a helper to identify if a rune is safe to process or should be dropped.
 func isSafe(r rune) bool {
-	return !(unicode.IsSpace(r) && r != ' ') &&
-		(isAllowedSpecialCharLabelValue(r) || isAlphanumeric(r) || isManagedSpecialChar(r))
+	return isAllowedSpecialCharLabelValue(r) || isAlphanumeric(r) || isManagedSpecialChar(r)
 }
 
 // isAlphanumeric returns true if the rune is an alphanumeric value.

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,6 @@ package formatting`
`3`	`3`	`import (`
`4`	`4`	`"slices"`
`5`	`5`	`"strings"`
`6`		`- "unicode"`
`7`	`6`
`8`	`7`	`"k8s.io/apimachinery/pkg/util/validation"`
`9`	`8`	`)`
`@@ -84,8 +83,7 @@ func pairs(m map[rune]string) []string {`
`84`	`83`
`85`	`84`	`// isSafe a helper to identify if a rune is safe to process or should be dropped.`
`86`	`85`	`func isSafe(r rune) bool {`
`87`		`- return !(unicode.IsSpace(r) && r != ' ') &&`
`88`		`- (isAllowedSpecialCharLabelValue(r) \|\| isAlphanumeric(r) \|\| isManagedSpecialChar(r))`
	`86`	`+ return isAllowedSpecialCharLabelValue(r) \|\| isAlphanumeric(r) \|\| isManagedSpecialChar(r)`
`89`	`87`	`}`
`90`	`88`
`91`	`89`	`// isAlphanumeric returns true if the rune is an alphanumeric value.`