test(github): remove redundant GraphQL test cases

Delete 7 test cases that duplicate coverage already provided by
SetupGitTree integration tests. The SetupGitTree helper automatically
constructs GraphQL responses from testdata directories, making manual
GraphQL response construction redundant for happy path testing.

Deleted from TestFetchTektonDirGraphQL (6 cases):
- successful fetch with yaml files
- no tekton directory
- tekton path is file not directory
- mixed yaml and yml extensions
- subdirectories with yaml files
- empty tekton directory

Deleted from TestGetTektonDirGraphQL (1 case):
- invalid yaml validation failure (duplicate of existing test)

Kept only error cases that cannot be represented via filesystem:
- http error, graphql errors, null blob content

This reduces test code by 213 lines (34% reduction) while maintaining
full coverage through integration tests.

Assisted-By: Claude Sonnet 4.5 <noreply@anthropic.com>

Author: aThorp96

pkg/provider/github/github_test.go

@@ -588,42 +588,6 @@ func TestGetTektonDirGraphQL(t *testing.T) {
 			},
 			expectedAPICount: 2, // 1 for get_default_branch + 1 for GraphQL
 		},
-		{
-			name: "invalid yaml validation failure",
-			event: &info.Event{
-				Organization:  "tekton",
-				Repository:    "cat",
-				TriggerTarget: triggertype.PullRequest,
-			},
-			skipSetupGitTree: true,
-			setup: func(t *testing.T, mux *http.ServeMux, event *info.Event) {
-				t.Helper()
-				shaDir := fmt.Sprintf("%x", sha256.Sum256([]byte("testdata/tree/badyaml")))
-				event.SHA = shaDir
-
-				mux.HandleFunc("/api/graphql", func(w http.ResponseWriter, _ *http.Request) {
-					_ = json.NewEncoder(w).Encode(map[string]any{
-						"data": map[string]any{
-							"repository": map[string]any{
-								"tektonTree": map[string]any{
-									"entries": []map[string]any{
-										{
-											"name":   "badyaml.yaml",
-											"type":   "blob",
-											"path":   "badyaml.yaml",
-											"oid":    "badyaml-sha",
-											"object": map[string]any{"text": "bad:\n  yaml:\n    - indent\n  error"},
-										},
-									},
-								},
-							},
-						},
-					})
-				})
-			},
-			wantErr:          "error unmarshalling yaml file badyaml.yaml",
-			expectedAPICount: 1, // Single GraphQL call
-		},
 	}
 
 	for _, tt := range tests {

pkg/provider/github/graphql_test.go

@@ -135,67 +135,6 @@ func TestFetchTektonDirGraphQL(t *testing.T) {
 		wantErr     bool
 		errContains string
 	}{
-		{
-			name: "successful fetch with yaml files",
-			handler: func(w http.ResponseWriter, _ *http.Request) {
-				w.Header().Set("X-RateLimit-Limit", "5000")
-				w.Header().Set("X-RateLimit-Remaining", "4999")
-				w.Header().Set("X-RateLimit-Reset", "1735689600")
-				_ = json.NewEncoder(w).Encode(map[string]any{
-					"data": map[string]any{
-						"repository": map[string]any{
-							"tektonTree": map[string]any{
-								"entries": []map[string]any{
-									{
-										"name": "pipeline.yaml",
-										"type": "blob",
-										"path": "pipeline.yaml",
-										"oid":  "abc123",
-										"object": map[string]any{
-											"text": "apiVersion: tekton.dev/v1",
-										},
-									},
-									{
-										"name": "task.yml",
-										"type": "blob",
-										"path": "task.yml",
-										"oid":  "def456",
-										"object": map[string]any{
-											"text": "kind: Task",
-										},
-									},
-									{
-										"name": "README.md",
-										"type": "blob",
-										"path": "README.md",
-										"oid":  "ghi789",
-										"object": map[string]any{
-											"text": "# README",
-										},
-									},
-								},
-							},
-						},
-					},
-				})
-			},
-			wantFiles: 2, // Only .yaml and .yml files
-		},
-		{
-			name: "no tekton directory",
-			handler: func(w http.ResponseWriter, _ *http.Request) {
-				w.Header().Set("X-RateLimit-Limit", "5000")
-				w.Header().Set("X-RateLimit-Remaining", "4998")
-				_ = json.NewEncoder(w).Encode(map[string]any{
-					"data": map[string]any{
-						"repository": map[string]any{
-							"tektonTree": nil,
-						},
-					},
-				})
-			},
-			wantFiles: 0,
-		},
 		{
 			name: "http error",
 			handler: func(w http.ResponseWriter, _ *http.Request) {
@@ -221,105 +160,6 @@ func TestFetchTektonDirGraphQL(t *testing.T) {
 			wantErr:     true,
 			errContains: "GraphQL errors",
 		},
-		{
-			name: "tekton path is file not directory",
-			handler: func(w http.ResponseWriter, _ *http.Request) {
-				w.Header().Set("X-RateLimit-Limit", "5000")
-				w.Header().Set("X-RateLimit-Remaining", "4995")
-				// GraphQL returns a Blob object instead of Tree when .tekton is a file
-				_ = json.NewEncoder(w).Encode(map[string]any{
-					"data": map[string]any{
-						"repository": map[string]any{
-							"tektonTree": map[string]any{
-								// Blob object has "text" field instead of "entries"
-								"text": "this is a file, not a directory",
-							},
-						},
-					},
-				})
-			},
-			wantErr:     true,
-			errContains: ".tekton has been found but is not a directory",
-		},
-		{
-			name: "mixed yaml and yml extensions",
-			handler: func(w http.ResponseWriter, _ *http.Request) {
-				w.Header().Set("X-RateLimit-Limit", "5000")
-				w.Header().Set("X-RateLimit-Remaining", "4994")
-				_ = json.NewEncoder(w).Encode(map[string]any{
-					"data": map[string]any{
-						"repository": map[string]any{
-							"tektonTree": map[string]any{
-								"entries": []map[string]any{
-									{
-										"name": "pipeline.yaml",
-										"type": "blob",
-										"path": "pipeline.yaml",
-										"oid":  "abc123",
-										"object": map[string]any{
-											"text": "kind: Pipeline",
-										},
-									},
-									{
-										"name": "task.yml",
-										"type": "blob",
-										"path": "task.yml",
-										"oid":  "def456",
-										"object": map[string]any{
-											"text": "kind: Task",
-										},
-									},
-								},
-							},
-						},
-					},
-				})
-			},
-			wantFiles: 2,
-		},
-		{
-			name: "subdirectories with yaml files",
-			handler: func(w http.ResponseWriter, _ *http.Request) {
-				w.Header().Set("X-RateLimit-Limit", "5000")
-				w.Header().Set("X-RateLimit-Remaining", "4993")
-				_ = json.NewEncoder(w).Encode(map[string]any{
-					"data": map[string]any{
-						"repository": map[string]any{
-							"tektonTree": map[string]any{
-								"entries": []map[string]any{
-									{
-										"name": "pipeline.yaml",
-										"type": "blob",
-										"path": "pipeline.yaml",
-										"oid":  "abc123",
-										"object": map[string]any{
-											"text": "kind: Pipeline",
-										},
-									},
-									{
-										"name":   "tasks",
-										"type":   "tree",
-										"path":   "tasks",
-										"oid":    "tree-sha",
-										"object": nil, // Subdirectories don't have blob content
-									},
-									{
-										"name": "build.yaml",
-										"type": "blob",
-										"path": "tasks/build.yaml",
-										"oid":  "def456",
-										"object": map[string]any{
-											"text": "kind: Task",
-										},
-									},
-								},
-							},
-						},
-					},
-				})
-			},
-			wantFiles: 2, // pipeline.yaml and tasks/build.yaml
-		},
 		{
 			name: "null blob content",
 			handler: func(w http.ResponseWriter, _ *http.Request) {
@@ -356,23 +196,6 @@ func TestFetchTektonDirGraphQL(t *testing.T) {
 			},
 			wantFiles: 1, // Only valid.yaml counted
 		},
-		{
-			name: "empty tekton directory",
-			handler: func(w http.ResponseWriter, _ *http.Request) {
-				w.Header().Set("X-RateLimit-Limit", "5000")
-				w.Header().Set("X-RateLimit-Remaining", "4991")
-				_ = json.NewEncoder(w).Encode(map[string]any{
-					"data": map[string]any{
-						"repository": map[string]any{
-							"tektonTree": map[string]any{
-								"entries": []map[string]any{},
-							},
-						},
-					},
-				})
-			},
-			wantFiles: 0,
-		},
 	}
 
 	for _, tc := range cases {