fix(bitbucketcloud): truncate commit status key to 40 char limit

Bitbucket Cloud limits commit status keys to 40 characters. Move
GetCheckName to the bitbucketcloud package to handle truncation locally,
add unit tests, fix the e2e test to correctly decode paginated commit
status responses, and add the Status type for commit status parsing.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: zakisk

pkg/provider/bitbucketcloud/bitbucket.go

@@ -114,7 +114,7 @@ func (v *Provider) CreateStatus(_ context.Context, event *info.Event, statusopts
 	}
 
 	cso := &bitbucket.CommitStatusOptions{
-		Key:         provider.GetCheckName(statusopts, v.pacInfo),
+		Key:         GetCheckName(statusopts, v.pacInfo),
 		Url:         detailsURL,
 		State:       string(state),
 		Description: statusopts.Title,
@@ -159,6 +159,33 @@ func (v *Provider) CreateStatus(_ context.Context, event *info.Event, statusopts
 	return nil
 }
 
+// GetCheckName returns the key for build commit status and the reason to have it
+// unique for bitbucket cloud is that the key is limited to 40 characters.
+// If the key is longer than 40 characters, it will be truncated to the first 40 characters.
+func GetCheckName(status status.StatusOpts, pacopts *info.PacOpts) string {
+	if pacopts.ApplicationName != "" {
+		if status.OriginalPipelineRunName == "" {
+			return pacopts.ApplicationName
+		}
+		key := fmt.Sprintf("%s / %s", pacopts.ApplicationName, status.OriginalPipelineRunName)
+		// if key is longer than 40 characters, truncate it to the first 40 characters
+		if len(key) > 40 {
+			// if the original pipeline run name is longer than 40 characters, truncate it to the first 40 characters
+			if len(status.OriginalPipelineRunName) > 40 {
+				return status.OriginalPipelineRunName[:40]
+			}
+			return key[:40]
+		}
+		return key
+	}
+
+	if len(status.OriginalPipelineRunName) > 40 {
+		return status.OriginalPipelineRunName[:40]
+	}
+
+	return status.OriginalPipelineRunName
+}
+
 func (v *Provider) GetCommitStatuses(_ context.Context, _ *info.Event) ([]provider.CommitStatusInfo, error) {
 	return nil, nil
 }

pkg/provider/bitbucketcloud/bitbucket_test.go

@@ -273,6 +273,86 @@ func TestGetCommitInfo(t *testing.T) {
 	}
 }
 
+func TestGetCheckName(t *testing.T) {
+	tests := []struct {
+		name     string
+		status   status.StatusOpts
+		pacopts  *info.PacOpts
+		expected string
+	}{
+		{
+			name:   "application name only no pipeline run name",
+			status: status.StatusOpts{OriginalPipelineRunName: ""},
+			pacopts: &info.PacOpts{
+				Settings: settings.Settings{ApplicationName: "MyApp"},
+			},
+			expected: "MyApp",
+		},
+		{
+			name:   "application name with short pipeline run name",
+			status: status.StatusOpts{OriginalPipelineRunName: "my-pr"},
+			pacopts: &info.PacOpts{
+				Settings: settings.Settings{ApplicationName: "MyApp"},
+			},
+			expected: "MyApp / my-pr",
+		},
+		{
+			name:   "key exactly 40 characters",
+			status: status.StatusOpts{OriginalPipelineRunName: strings.Repeat("a", 40-len("App / "))},
+			pacopts: &info.PacOpts{
+				Settings: settings.Settings{ApplicationName: "App"},
+			},
+			expected: "App / " + strings.Repeat("a", 34),
+		},
+		{
+			name:   "key longer than 40 characters truncated",
+			status: status.StatusOpts{OriginalPipelineRunName: "this-is-a-very-long-pipeline-run-name"},
+			pacopts: &info.PacOpts{
+				Settings: settings.Settings{ApplicationName: "MyApplication"},
+			},
+			expected: "MyApplication / this-is-a-very-long-pipe",
+		},
+		{
+			name:   "original pipeline run name longer than 40 truncated",
+			status: status.StatusOpts{OriginalPipelineRunName: strings.Repeat("b", 50)},
+			pacopts: &info.PacOpts{
+				Settings: settings.Settings{ApplicationName: "App"},
+			},
+			expected: strings.Repeat("b", 40),
+		},
+		{
+			name:   "no application name short pipeline run name",
+			status: status.StatusOpts{OriginalPipelineRunName: "my-pr"},
+			pacopts: &info.PacOpts{
+				Settings: settings.Settings{ApplicationName: ""},
+			},
+			expected: "my-pr",
+		},
+		{
+			name:   "no application name pipeline run name longer than 40",
+			status: status.StatusOpts{OriginalPipelineRunName: strings.Repeat("c", 50)},
+			pacopts: &info.PacOpts{
+				Settings: settings.Settings{ApplicationName: ""},
+			},
+			expected: strings.Repeat("c", 40),
+		},
+		{
+			name:   "no application name no pipeline run name",
+			status: status.StatusOpts{OriginalPipelineRunName: ""},
+			pacopts: &info.PacOpts{
+				Settings: settings.Settings{ApplicationName: ""},
+			},
+			expected: "",
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			got := GetCheckName(tt.status, tt.pacopts)
+			assert.Equal(t, tt.expected, got)
+		})
+	}
+}
+
 func TestCreateStatus(t *testing.T) {
 	originalPipelineRunName := "hello-af9ch"
 	tests := []struct {

pkg/provider/bitbucketcloud/types/types.go

@@ -125,6 +125,19 @@ type Comments struct {
 	Values []Comment
 }
 
+type Status struct {
+	Key         string     `json:"key"`
+	Type        string     `json:"type"`
+	State       string     `json:"state"`
+	Name        string     `json:"name"`
+	RefName     string     `json:"refname"`
+	Commit      Commit     `json:"commit"`
+	URL         string     `json:"url"`
+	Repository  Repository `json:"repository"`
+	Description string     `json:"description"`
+	Links       Links      `json:"links"`
+}
+
 type CommitStatusState string
 
 // See: https://api.bitbucket.org/swagger.json attribute:

test/bitbucket_cloud_pullrequest_test.go

@@ -5,11 +5,14 @@ package test
 import (
 	"context"
 	"fmt"
+	"strings"
 	"testing"
 	"time"
 
 	"github.com/ktrysmt/go-bitbucket"
+	"github.com/mitchellh/mapstructure"
 	"github.com/openshift-pipelines/pipelines-as-code/pkg/params/triggertype"
+	"github.com/openshift-pipelines/pipelines-as-code/pkg/provider/bitbucketcloud/types"
 	tbb "github.com/openshift-pipelines/pipelines-as-code/test/pkg/bitbucketcloud"
 	"github.com/openshift-pipelines/pipelines-as-code/test/pkg/options"
 	"github.com/openshift-pipelines/pipelines-as-code/test/pkg/payload"
@@ -107,6 +110,65 @@ func TestBitbucketCloudPullRequestCancelInProgressMerged(t *testing.T) {
 	assert.Equal(t, prs.Items[0].GetStatusCondition().GetCondition(apis.ConditionSucceeded).GetReason(), "Cancelled", "should have been cancelled")
 }
 
+func TestBitbucketCloudPRBuildStatusReported(t *testing.T) {
+	targetNS := names.SimpleNameGenerator.RestrictLengthWithRandomSuffix("pac-e2e-ns")
+	ctx := context.Background()
+
+	runcnx, opts, bprovider, err := tbb.Setup(ctx)
+	if err != nil {
+		t.Skip(err.Error())
+		return
+	}
+	bcrepo := tbb.CreateCRD(ctx, t, bprovider, runcnx, opts, targetNS)
+	targetRefName := names.SimpleNameGenerator.RestrictLengthWithRandomSuffix("pac-e2e-test")
+	title := "TestPullRequest - " + targetRefName
+
+	entries, err := payload.GetEntries(
+		map[string]string{".tekton/pipelinerun.yaml": "testdata/pipelinerun.yaml"},
+		targetNS, options.MainBranch, triggertype.PullRequest.String(), map[string]string{})
+	assert.NilError(t, err)
+
+	pr, repobranch := tbb.MakePR(t, bprovider, runcnx, bcrepo, opts, title, targetRefName, entries)
+	defer tbb.TearDown(ctx, t, runcnx, bprovider, opts, pr.ID, targetRefName, targetNS, false)
+
+	hash, ok := repobranch.Target["hash"].(string)
+	assert.Assert(t, ok)
+
+	sopt := twait.SuccessOpt{
+		TargetNS:        targetNS,
+		OnEvent:         triggertype.PullRequest.String(),
+		NumberofPRMatch: 1,
+		SHA:             hash,
+		Title:           title,
+		MinNumberStatus: 1,
+	}
+	twait.Succeeded(ctx, t, runcnx, opts, sopt)
+
+	resp, err := bprovider.Client().Repositories.Commits.GetCommitStatuses(&bitbucket.CommitsOptions{
+		Owner:    opts.Organization,
+		RepoSlug: opts.Repo,
+		Revision: hash,
+	})
+	assert.NilError(t, err)
+
+	statusesMap, ok := resp.(map[string]any)
+	assert.Equal(t, ok, true, "cannot convert Bitbucket commit statuses response to map[string]any")
+
+	statues := []*types.Status{}
+
+	err = mapstructure.Decode(statusesMap["values"], &statues)
+	assert.NilError(t, err, fmt.Sprintf("cannot decode Bitbucket commit statuses from response payload: %v", err))
+
+	foundStatus := false
+	for _, status := range statues {
+		if strings.Contains(status.Key, "pipelinerun-") {
+			foundStatus = true
+			break
+		}
+	}
+	assert.Equal(t, foundStatus, true, "should have found the status for the pipeline run")
+}
+
 // Local Variables:
 // compile-command: "go test -tags=e2e -v -run TestBitbucketCloudPullRequest$ ."
 // End: