fix: label values when dot are present

Label values can't start nor finish with a `.` (dot).
This contribution ensures that any dot at the beginning or
end of a label value is removed.

Signed-off-by: Francesco Ilario <filario@redhat.com>

Author: filariow

pkg/formatting/k8labels.go

@@ -18,8 +18,8 @@ func CleanValueKubernetes(s string) string {
 	}
 
 	replasoeur := strings.NewReplacer(":", "-", "/", "-", " ", "_", "[", "__", "]", "__")
-	s = strings.TrimRight(s, " -_[]")
-	s = strings.TrimLeft(s, " -_[]")
+	s = strings.TrimRight(s, " .-_[]")
+	s = strings.TrimLeft(s, " .-_[]")
 	replaced := replasoeur.Replace(s)
 	return strings.TrimSpace(replaced)
 }

pkg/formatting/k8labels_test.go

@@ -57,6 +57,21 @@ func TestK8LabelsCleanup(t *testing.T) {
 			str:  "secret:name/with_underscores",
 			want: "secret-name-with_underscores",
 		},
+		{
+			name: "starts with a .",
+			str:  ".i-start-with-a-dot",
+			want: "i-start-with-a-dot",
+		},
+		{
+			name: "ends with a .",
+			str:  "i-end-with-a-dot.",
+			want: "i-end-with-a-dot",
+		},
+		{
+			name: "long value once cut starts with a .",
+			str:  "everythingbeforethedotisdropped.thesehereare61chars-62withdot-previouscharacterswillbedropped",
+			want: "thesehereare61chars-62withdot-previouscharacterswillbedropped",
+		},
 	}
 
 	for _, tt := range tests {