Skip to content

Commit f9c939d

Browse files
zakiskclaude
andcommitted
fix(ci): remove --insecure-skip-tls-verify flag from gosmee client
The e2e workflow now installs the minica CA certificate into the system trust store, so gosmee no longer needs to skip TLS verification. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent ce4774d commit f9c939d

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

.github/workflows/e2e.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ jobs:
186186
env:
187187
PYSMEE_URL: ${{ secrets.PYSMEE_URL }}
188188
run: |
189-
nohup gosmee client --insecure-skip-tls-verify --saveDir /tmp/gosmee-replay "${PYSMEE_URL}" "https://${CONTROLLER_DOMAIN_URL}" > /tmp/gosmee-main.log 2>&1 &
189+
nohup gosmee client --saveDir /tmp/gosmee-replay "${PYSMEE_URL}" "https://${CONTROLLER_DOMAIN_URL}" > /tmp/gosmee-main.log 2>&1 &
190190
191191
- name: Generate unique gosmee URL for Gitea tests
192192
if: startsWith(matrix.provider, 'gitea') || matrix.provider == 'concurrency'
@@ -201,7 +201,7 @@ jobs:
201201
env:
202202
TEST_GITEA_SMEEURL: ${{ steps.gosmee-url.outputs.url }}
203203
run: |
204-
nohup gosmee client --insecure-skip-tls-verify --saveDir /tmp/gosmee-replay "${TEST_GITEA_SMEEURL}" "https://${CONTROLLER_DOMAIN_URL}" >> /tmp/gosmee-main.log 2>&1 &
204+
nohup gosmee client --saveDir /tmp/gosmee-replay "${TEST_GITEA_SMEEURL}" "https://${CONTROLLER_DOMAIN_URL}" >> /tmp/gosmee-main.log 2>&1 &
205205
206206
- name: Generate unique gosmee URL for GitLab tests
207207
if: matrix.provider == 'gitlab_bitbucket'
@@ -216,12 +216,12 @@ jobs:
216216
env:
217217
TEST_GITLAB_SMEEURL: ${{ steps.gosmee-gitlab-url.outputs.url }}
218218
run: |
219-
nohup gosmee client --insecure-skip-tls-verify --saveDir /tmp/gosmee-replay-gitlab "${TEST_GITLAB_SMEEURL}" "https://${CONTROLLER_DOMAIN_URL}" >> /tmp/gosmee-gitlab.log 2>&1 &
219+
nohup gosmee client --saveDir /tmp/gosmee-replay-gitlab "${TEST_GITLAB_SMEEURL}" "https://${CONTROLLER_DOMAIN_URL}" >> /tmp/gosmee-gitlab.log 2>&1 &
220220
221221
- name: Run gosmee for second controller GHE App
222222
if: startsWith(matrix.provider, 'github_ghe') || matrix.provider == 'concurrency'
223223
run: |
224-
nohup gosmee client --insecure-skip-tls-verify --saveDir /tmp/gosmee-replay-ghe "${TEST_GITHUB_SECOND_SMEE_URL}" "https://ghe.paac-127-0-0-1.nip.io" >> /tmp/gosmee-ghe.log 2>&1 &
224+
nohup gosmee client --saveDir /tmp/gosmee-replay-ghe "${TEST_GITHUB_SECOND_SMEE_URL}" "https://ghe.paac-127-0-0-1.nip.io" >> /tmp/gosmee-ghe.log 2>&1 &
225225
226226
- name: Generate unique gosmee URL for GHE webhook tests
227227
if: startsWith(matrix.provider, 'github_ghe') || matrix.provider == 'concurrency'
@@ -236,7 +236,7 @@ jobs:
236236
env:
237237
TEST_GITHUB_SECOND_WEBHOOK_SMEE_URL: ${{ steps.gosmee-ghe-webhook-url.outputs.url }}
238238
run: |
239-
nohup gosmee client --insecure-skip-tls-verify --saveDir /tmp/gosmee-replay-ghe-webhook "${TEST_GITHUB_SECOND_WEBHOOK_SMEE_URL}" "https://ghe.paac-127-0-0-1.nip.io" >> /tmp/gosmee-ghe-webhook.log 2>&1 &
239+
nohup gosmee client --saveDir /tmp/gosmee-replay-ghe-webhook "${TEST_GITHUB_SECOND_WEBHOOK_SMEE_URL}" "https://ghe.paac-127-0-0-1.nip.io" >> /tmp/gosmee-ghe-webhook.log 2>&1 &
240240
241241
- name: Setup tmate session
242242
uses: mxschmitt/action-tmate@35b54afac29c97fb54faba5b513f8fbd1882f113 # v3

0 commit comments

Comments
 (0)