Skip to content

Commit fe709ae

Browse files
zakiskclaude
authored andcommitted
fix(ci): restore --insecure-skip-tls-verify and unpin gosmee version
gosmee v0.31.1 fixed an inverted TLS flag (InsecureSkipVerify was negated), so the flag now works correctly. Restore it for e2e tests that use self-signed minica certificates and unpin the version to pick up the security fixes in v0.31.1+. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Zaki Shaikh <zashaikh@redhat.com>
1 parent f9c939d commit fe709ae

1 file changed

Lines changed: 5 additions & 6 deletions

File tree

.github/workflows/e2e.yaml

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,6 @@ jobs:
163163
uses: jaxxstorm/action-install-gh-release@25e24d2d23ae098373794ef1d6faecb48ee52da8 # v3.0.0
164164
with:
165165
repo: chmouel/gosmee
166-
tag: v0.31.0
167166

168167
- name: Install Snazy
169168
uses: jaxxstorm/action-install-gh-release@25e24d2d23ae098373794ef1d6faecb48ee52da8 # v3.0.0
@@ -186,7 +185,7 @@ jobs:
186185
env:
187186
PYSMEE_URL: ${{ secrets.PYSMEE_URL }}
188187
run: |
189-
nohup gosmee client --saveDir /tmp/gosmee-replay "${PYSMEE_URL}" "https://${CONTROLLER_DOMAIN_URL}" > /tmp/gosmee-main.log 2>&1 &
188+
nohup gosmee client --insecure-skip-tls-verify --saveDir /tmp/gosmee-replay "${PYSMEE_URL}" "https://${CONTROLLER_DOMAIN_URL}" > /tmp/gosmee-main.log 2>&1 &
190189
191190
- name: Generate unique gosmee URL for Gitea tests
192191
if: startsWith(matrix.provider, 'gitea') || matrix.provider == 'concurrency'
@@ -201,7 +200,7 @@ jobs:
201200
env:
202201
TEST_GITEA_SMEEURL: ${{ steps.gosmee-url.outputs.url }}
203202
run: |
204-
nohup gosmee client --saveDir /tmp/gosmee-replay "${TEST_GITEA_SMEEURL}" "https://${CONTROLLER_DOMAIN_URL}" >> /tmp/gosmee-main.log 2>&1 &
203+
nohup gosmee client --insecure-skip-tls-verify --saveDir /tmp/gosmee-replay "${TEST_GITEA_SMEEURL}" "https://${CONTROLLER_DOMAIN_URL}" >> /tmp/gosmee-main.log 2>&1 &
205204
206205
- name: Generate unique gosmee URL for GitLab tests
207206
if: matrix.provider == 'gitlab_bitbucket'
@@ -216,12 +215,12 @@ jobs:
216215
env:
217216
TEST_GITLAB_SMEEURL: ${{ steps.gosmee-gitlab-url.outputs.url }}
218217
run: |
219-
nohup gosmee client --saveDir /tmp/gosmee-replay-gitlab "${TEST_GITLAB_SMEEURL}" "https://${CONTROLLER_DOMAIN_URL}" >> /tmp/gosmee-gitlab.log 2>&1 &
218+
nohup gosmee client --insecure-skip-tls-verify --saveDir /tmp/gosmee-replay-gitlab "${TEST_GITLAB_SMEEURL}" "https://${CONTROLLER_DOMAIN_URL}" >> /tmp/gosmee-gitlab.log 2>&1 &
220219
221220
- name: Run gosmee for second controller GHE App
222221
if: startsWith(matrix.provider, 'github_ghe') || matrix.provider == 'concurrency'
223222
run: |
224-
nohup gosmee client --saveDir /tmp/gosmee-replay-ghe "${TEST_GITHUB_SECOND_SMEE_URL}" "https://ghe.paac-127-0-0-1.nip.io" >> /tmp/gosmee-ghe.log 2>&1 &
223+
nohup gosmee client --insecure-skip-tls-verify --saveDir /tmp/gosmee-replay-ghe "${TEST_GITHUB_SECOND_SMEE_URL}" "https://ghe.paac-127-0-0-1.nip.io" >> /tmp/gosmee-ghe.log 2>&1 &
225224
226225
- name: Generate unique gosmee URL for GHE webhook tests
227226
if: startsWith(matrix.provider, 'github_ghe') || matrix.provider == 'concurrency'
@@ -236,7 +235,7 @@ jobs:
236235
env:
237236
TEST_GITHUB_SECOND_WEBHOOK_SMEE_URL: ${{ steps.gosmee-ghe-webhook-url.outputs.url }}
238237
run: |
239-
nohup gosmee client --saveDir /tmp/gosmee-replay-ghe-webhook "${TEST_GITHUB_SECOND_WEBHOOK_SMEE_URL}" "https://ghe.paac-127-0-0-1.nip.io" >> /tmp/gosmee-ghe-webhook.log 2>&1 &
238+
nohup gosmee client --insecure-skip-tls-verify --saveDir /tmp/gosmee-replay-ghe-webhook "${TEST_GITHUB_SECOND_WEBHOOK_SMEE_URL}" "https://ghe.paac-127-0-0-1.nip.io" >> /tmp/gosmee-ghe-webhook.log 2>&1 &
240239
241240
- name: Setup tmate session
242241
uses: mxschmitt/action-tmate@35b54afac29c97fb54faba5b513f8fbd1882f113 # v3

0 commit comments

Comments
 (0)