Skip to content

fix: improve unexpected event filtering in tests#2688

Merged
zakisk merged 1 commit into
tektoncd:mainfrom
chmouel:fix-improve-unexpected-event-filtering-in-tests
Apr 22, 2026
Merged

fix: improve unexpected event filtering in tests#2688
zakisk merged 1 commit into
tektoncd:mainfrom
chmouel:fix-improve-unexpected-event-filtering-in-tests

Conversation

@chmouel

@chmouel chmouel commented Apr 16, 2026

Copy link
Copy Markdown
Member

📝 Description of the Change

Refactored the event checking logic to specifically target and report
warning events instead of filtering out individual event reasons. This
ensures that unexpected errors are correctly identified during test
validation.

🔗 Linked GitHub Issue

Fixes #

🧪 Testing Strategy

  • Unit tests
  • Integration tests
  • End-to-end tests
  • Manual testing
  • Not Applicable

🤖 AI Assistance

AI assistance can be used for various tasks, such as code generation,
documentation, or testing.

Please indicate whether you have used AI assistance
for this PR and provide details if applicable.

  • I have not used any AI assistance for this PR.
  • I have used AI assistance for this PR.

Important

Slop will be simply rejected, if you are using AI assistance you need to make sure you
understand the code generated and that it meets the project's standards. you
need at least know how to run the code and deploy it (if needed). See
startpaac to make it easy
to deploy and test your code changes.

If the majority of the code in this PR was generated by an AI, please add a Co-authored-by trailer to your commit message.
For example:

Co-authored-by: Claude noreply@anthropic.com

✅ Submitter Checklist

  • 📝 My commit messages are clear, informative, and follow the project's How to write a git commit message guide. The Gitlint linter ensures in CI it's properly validated
  • ✨ I have ensured my commit message prefix (e.g., fix:, feat:) matches the "Type of Change" I selected above.
  • ♽ I have run make test and make lint locally to check for and fix any
    issues. For an efficient workflow, I have considered installing
    pre-commit and running pre-commit install to
    automate these checks.
  • 📖 I have added or updated documentation for any user-facing changes.
  • 🧪 I have added sufficient unit tests for my code changes.
  • 🎁 I have added end-to-end tests where feasible. See README for more details.
  • 🔎 I have addressed any CI test flakiness or provided a clear reason to bypass it.
  • If adding a provider feature, I have filled in the following and updated the provider documentation:
    • GitHub App
    • GitHub Webhook
    • Gitea/Forgejo
    • GitLab
    • Bitbucket Cloud
    • Bitbucket Data Center

@codecov-commenter

codecov-commenter commented Apr 16, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.00%. Comparing base (9c4e9cb) to head (ac778ba).
⚠️ Report is 1 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2688   +/-   ##
=======================================
  Coverage   59.00%   59.00%           
=======================================
  Files         208      208           
  Lines       20436    20436           
=======================================
  Hits        12059    12059           
  Misses       7603     7603           
  Partials      774      774           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chmouel

chmouel commented Apr 16, 2026

Copy link
Copy Markdown
Member Author

made watcher in debug pipelines-as-code/startpaac#24 so this may be needed,

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the event checking logic in test/pkg/gitea/test.go by introducing a new unexpectedEvents helper function. This helper filters for non-normal events, replacing the previous logic that specifically excluded 'CancelInProgress' reasons. The checkEvents function now logs all event reasons before failing if any unexpected events are detected. I have no feedback to provide.

Refactored the event checking logic to specifically target and report
warning events instead of filtering out individual event reasons. This
ensures that unexpected errors are correctly identified during test
validation.
@zakisk zakisk force-pushed the fix-improve-unexpected-event-filtering-in-tests branch from 350792f to ac778ba Compare April 22, 2026 11:26
@zakisk zakisk merged commit 6b69972 into tektoncd:main Apr 22, 2026
13 checks passed
@chmouel chmouel deleted the fix-improve-unexpected-event-filtering-in-tests branch April 22, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants