fix(bitbucket-cloud): resolve CEL expression failure on push events#2704
Conversation
5216da0 to
f4c95c1
Compare
There was a problem hiding this comment.
Code Review
This pull request refactors Bitbucket Cloud payload parsing to use typed trigger constants and introduces a new E2E test for CEL expressions on push events. It also refactors test helpers to support push-only scenarios by separating branch creation from pull request creation and updating the teardown logic to handle cases without a pull request number. I have no feedback to provide.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2704 +/- ##
==========================================
- Coverage 59.00% 59.00% -0.01%
==========================================
Files 208 208
Lines 20436 20435 -1
==========================================
- Hits 12059 12058 -1
Misses 7603 7603
Partials 774 774 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f4c95c1 to
3bee419
Compare
Bitbucket Cloud push events set processedEvent.Event to the string
"push", but CEL evaluation expects Event to be a JSON object
(map[string]interface{}). This caused all CEL expressions to fail
with "cannot unmarshal string into Go value of type
map[string]interface{}". Remove the incorrect Event assignment and
use triggertype constants for TriggerTarget and EventType.
Signed-off-by: Zaki Shaikh <zashaikh@redhat.com>
3bee419 to
e312653
Compare
Bitbucket Cloud push events set processedEvent.Event to the string "push", but CEL evaluation expects Event to be a JSON object (map[string]interface{}). This caused all CEL expressions to fail with "cannot unmarshal string into Go value of type map[string]interface{}". Remove the incorrect Event assignment and use triggertype constants for TriggerTarget and EventType.
Assisted-by: Claude Opus 4.6 (via Claude Code)
📝 Description of the Change
🔗 Linked GitHub Issue
Fixes #2335
🧪 Testing Strategy
🤖 AI Assistance
AI assistance can be used for various tasks, such as code generation,
documentation, or testing.
Please indicate whether you have used AI assistance
for this PR and provide details if applicable.
Important
Slop will be simply rejected, if you are using AI assistance you need to make sure you
understand the code generated and that it meets the project's standards. you
need at least know how to run the code and deploy it (if needed). See
startpaac to make it easy
to deploy and test your code changes.
If the majority of the code in this PR was generated by an AI, please add a
Co-authored-bytrailer to your commit message.For example:
Co-authored-by: Claude noreply@anthropic.com
✅ Submitter Checklist
fix:,feat:) matches the "Type of Change" I selected above.make testandmake lintlocally to check for and fix anyissues. For an efficient workflow, I have considered installing
pre-commit and running
pre-commit installtoautomate these checks.