Skip to content

fix: fix skip-install option to bootstrap command#2709

Merged
theakshaypant merged 1 commit into
tektoncd:mainfrom
chmouel:add-skip-install-option
Apr 29, 2026
Merged

fix: fix skip-install option to bootstrap command#2709
theakshaypant merged 1 commit into
tektoncd:mainfrom
chmouel:add-skip-install-option

Conversation

@chmouel
Copy link
Copy Markdown
Member

@chmouel chmouel commented Apr 28, 2026

Updated the bootstrap process to allow users to bypass the installation check. This change prevented the command from failing when Pipelines as Code is already present in the cluster, enabling users to skip the automatic installation step when it is not required.

tested as working on openshift cluster:

before:

%   tkn pac bootstrap github-app \
    -n pipelines-as-code \
    --skip-install \
    --route-url "https://$(oc get route pipelines-as-code-controller -n pipelines-as-code -o jsonpath='{.spec.host}')" \
    --github-application-name "blahblah \
    --github-organization-name org
Error: pipelines as Code is already installed, please pass --force-install to override existin

after:

working

Closes #2708

📝 Description of the Change

🔗 Linked GitHub Issue

Fixes #

🧪 Testing Strategy

  • Unit tests
  • Integration tests
  • End-to-end tests
  • Manual testing
  • Not Applicable

🤖 AI Assistance

AI assistance can be used for various tasks, such as code generation,
documentation, or testing.

Please indicate whether you have used AI assistance
for this PR and provide details if applicable.

  • I have not used any AI assistance for this PR.
  • I have used AI assistance for this PR.

Important

Slop will be simply rejected, if you are using AI assistance you need to make sure you
understand the code generated and that it meets the project's standards. you
need at least know how to run the code and deploy it (if needed). See
startpaac to make it easy
to deploy and test your code changes.

If the majority of the code in this PR was generated by an AI, please add a Co-authored-by trailer to your commit message.
For example:

Co-authored-by: Claude noreply@anthropic.com

✅ Submitter Checklist

  • 📝 My commit messages are clear, informative, and follow the project's How to write a git commit message guide. The Gitlint linter ensures in CI it's properly validated
  • ✨ I have ensured my commit message prefix (e.g., fix:, feat:) matches the "Type of Change" I selected above.
  • ♽ I have run make test and make lint locally to check for and fix any
    issues. For an efficient workflow, I have considered installing
    pre-commit and running pre-commit install to
    automate these checks.
  • 📖 I have added or updated documentation for any user-facing changes.
  • 🧪 I have added sufficient unit tests for my code changes.
  • 🎁 I have added end-to-end tests where feasible. See README for more details.
  • 🔎 I have addressed any CI test flakiness or provided a clear reason to bypass it.
  • If adding a provider feature, I have filled in the following and updated the provider documentation:
    • GitHub App
    • GitHub Webhook
    • Gitea/Forgejo
    • GitLab
    • Bitbucket Cloud
    • Bitbucket Data Center

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 28, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 59.12%. Comparing base (357d970) to head (98b90fa).

Files with missing lines Patch % Lines
pkg/cmd/tknpac/bootstrap/bootstrap.go 0.00% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2709   +/-   ##
=======================================
  Coverage   59.12%   59.12%           
=======================================
  Files         208      208           
  Lines       20512    20512           
=======================================
  Hits        12127    12127           
  Misses       7612     7612           
  Partials      773      773           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gemini-code-assist
Copy link
Copy Markdown

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.

Updated the bootstrap process to allow users to bypass the installation
check. This change prevented the command from failing when Pipelines as
Code is already present in the cluster, enabling users to skip the
automatic installation step when it is not required.

Closes tektoncd#2708
@zakisk zakisk force-pushed the add-skip-install-option branch from a1ce441 to 98b90fa Compare April 28, 2026 17:17
@theakshaypant theakshaypant merged commit e951778 into tektoncd:main Apr 29, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bootstrap github-app: --skip-install does not bypass the "already installed" guard

3 participants