Skip to content

chore(github): emit event when API rate limit exceeded#2715

Merged
zakisk merged 1 commit into
tektoncd:mainfrom
theakshaypant:chore/github-rate-limit-error
May 6, 2026
Merged

chore(github): emit event when API rate limit exceeded#2715
zakisk merged 1 commit into
tektoncd:mainfrom
theakshaypant:chore/github-rate-limit-error

Conversation

@theakshaypant

Copy link
Copy Markdown
Member

📝 Description of the Change

Add Kubernetes event emission via EmitMessage when GitHub API rate limit remaining hits zero. This surfaces rate limit exhaustion as a Repository event, improving observability for operators.

🔗 Linked GitHub Issue

N/A

🧪 Testing Strategy

  • Unit tests
  • Integration tests
  • End-to-end tests
  • Manual testing
  • Not Applicable

🤖 AI Assistance

AI assistance can be used for various tasks, such as code generation,
documentation, or testing.

Please indicate whether you have used AI assistance
for this PR and provide details if applicable.

  • I have not used any AI assistance for this PR.
  • I have used AI assistance for this PR.

Important

Slop will be simply rejected, if you are using AI assistance you need to make sure you
understand the code generated and that it meets the project's standards. you
need at least know how to run the code and deploy it (if needed). See
startpaac to make it easy
to deploy and test your code changes.

If the majority of the code in this PR was generated by an AI, please add a Co-authored-by trailer to your commit message.
For example:

Co-authored-by: Claude noreply@anthropic.com

✅ Submitter Checklist

  • 📝 My commit messages are clear, informative, and follow the project's How to write a git commit message guide. The Gitlint linter ensures in CI it's properly validated
  • ✨ I have ensured my commit message prefix (e.g., fix:, feat:) matches the "Type of Change" I selected above.
  • ♽ I have run make test and make lint locally to check for and fix any
    issues. For an efficient workflow, I have considered installing
    pre-commit and running pre-commit install to
    automate these checks.
  • 📖 I have added or updated documentation for any user-facing changes.
  • 🧪 I have added sufficient unit tests for my code changes.
  • 🎁 I have added end-to-end tests where feasible. See README for more details.
  • 🔎 I have addressed any CI test flakiness or provided a clear reason to bypass it.
  • If adding a provider feature, I have filled in the following and updated the provider documentation:
    • GitHub App
    • GitHub Webhook
    • Gitea/Forgejo
    • GitLab
    • Bitbucket Cloud
    • Bitbucket Data Center

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a check for exhausted GitHub API rate limits, logging an error and emitting an event when the limit is reached. Feedback identified a potential nil pointer dereference on the event emitter, which could cause a panic if the provider is not fully initialized.

Comment thread pkg/provider/github/profiler.go Outdated
@theakshaypant theakshaypant force-pushed the chore/github-rate-limit-error branch from e6574ea to cd5908a Compare May 6, 2026 06:16
@codecov-commenter

codecov-commenter commented May 6, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.22%. Comparing base (eda5331) to head (101db16).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/provider/github/profiler.go 0.00% 7 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2715      +/-   ##
==========================================
- Coverage   59.24%   59.22%   -0.03%     
==========================================
  Files         208      208              
  Lines       20566    20573       +7     
==========================================
  Hits        12184    12184              
- Misses       7610     7617       +7     
  Partials      772      772              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Add Kubernetes event emission via EmitMessage when GitHub API rate
limit remaining hits zero. This surfaces rate limit exhaustion as
a Repository event, improving observability for operators.

Signed-off-by: Akshay Pant <akpant@redhat.com>
@theakshaypant theakshaypant force-pushed the chore/github-rate-limit-error branch from cd5908a to 101db16 Compare May 6, 2026 09:31
@theakshaypant theakshaypant marked this pull request as ready for review May 6, 2026 10:53
@zakisk zakisk merged commit c615efb into tektoncd:main May 6, 2026
22 of 23 checks passed
@theakshaypant theakshaypant deleted the chore/github-rate-limit-error branch May 6, 2026 12:11
@mathur07

mathur07 commented May 8, 2026

Copy link
Copy Markdown
Contributor

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants