chore(github): emit event when API rate limit exceeded#2715
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds a check for exhausted GitHub API rate limits, logging an error and emitting an event when the limit is reached. Feedback identified a potential nil pointer dereference on the event emitter, which could cause a panic if the provider is not fully initialized.
e6574ea to
cd5908a
Compare
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2715 +/- ##
==========================================
- Coverage 59.24% 59.22% -0.03%
==========================================
Files 208 208
Lines 20566 20573 +7
==========================================
Hits 12184 12184
- Misses 7610 7617 +7
Partials 772 772 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add Kubernetes event emission via EmitMessage when GitHub API rate limit remaining hits zero. This surfaces rate limit exhaustion as a Repository event, improving observability for operators. Signed-off-by: Akshay Pant <akpant@redhat.com>
cd5908a to
101db16
Compare
zakisk
approved these changes
May 6, 2026
Contributor
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description of the Change
Add Kubernetes event emission via EmitMessage when GitHub API rate limit remaining hits zero. This surfaces rate limit exhaustion as a Repository event, improving observability for operators.
🔗 Linked GitHub Issue
N/A
🧪 Testing Strategy
🤖 AI Assistance
AI assistance can be used for various tasks, such as code generation,
documentation, or testing.
Please indicate whether you have used AI assistance
for this PR and provide details if applicable.
Important
Slop will be simply rejected, if you are using AI assistance you need to make sure you
understand the code generated and that it meets the project's standards. you
need at least know how to run the code and deploy it (if needed). See
startpaac to make it easy
to deploy and test your code changes.
If the majority of the code in this PR was generated by an AI, please add a
Co-authored-bytrailer to your commit message.For example:
Co-authored-by: Claude noreply@anthropic.com
✅ Submitter Checklist
fix:,feat:) matches the "Type of Change" I selected above.make testandmake lintlocally to check for and fix anyissues. For an efficient workflow, I have considered installing
pre-commit and running
pre-commit installtoautomate these checks.