feat(accessibility): add screen reader support for peer lists

mukthar777 · mukthar777 · commit 6cffcbff8bbe · 2026-04-08T07:59:59.000+05:30
diff --git a/Telegram/SourceFiles/boxes/peer_list_box.cpp b/Telegram/SourceFiles/boxes/peer_list_box.cpp
@@ -38,6 +38,7 @@ For license and copyright information please follow this link:
 
 #include <xxhash.h> // XXH64.
 #include <QtWidgets/QApplication>
+#include "base/screen_reader_state.h"
 
 [[nodiscard]] PeerListRowId UniqueRowIdFromString(const QString &d) {
 	return XXH64(d.data(), d.size() * sizeof(ushort), 0);
@@ -452,6 +453,10 @@ std::unique_ptr<PeerListRow> PeerListController::createSearchRow(
 	return nullptr;
 }
 
+QString PeerListController::accessibilityName() const {
+	return u"Peer list"_q;
+}
+
 std::unique_ptr<PeerListState> PeerListController::saveState() const {
 	return delegate()->peerListSaveState();
 }
@@ -600,6 +605,10 @@ PeerListRow::PeerListRow(PeerListRowId id)
 
 PeerListRow::~PeerListRow() = default;
 
+bool PeerListRow::checkable() const {
+	return _checkbox != nullptr;
+}
+
 bool PeerListRow::checked() const {
 	return _checkbox && _checkbox->checked();
 }
@@ -1025,6 +1034,11 @@ PeerListContent::PeerListContent(
 		update();
 	}, lifetime());
 
+	base::ScreenReaderState::Instance()->activeValue(
+	) | rpl::on_next([this](bool active) {
+		setFocusPolicy(active ? Qt::TabFocus : Qt::NoFocus);
+	}, lifetime());
+
 	using UpdateFlag = Data::PeerUpdate::Flag;
 	_controller->session().changes().peerUpdates(
 		UpdateFlag::Name | UpdateFlag::Photo | UpdateFlag::EmojiStatus
@@ -1043,6 +1057,13 @@ PeerListContent::PeerListContent(
 	}, lifetime());
 
 	_repaintByStatus.setCallback([this] { update(); });
+
+	_selectedIndex.changes(
+	) | rpl::on_next([=](int index) {
+		if (index >= 0) {
+			accessibilityChildFocused(index);
+		}
+	}, lifetime());
 }
 
 void PeerListContent::setMode(Mode mode) {
@@ -1114,6 +1135,12 @@ void PeerListContent::changeCheckState(
 	row->setChecked(checked, _st.item.checkbox, animated, [=] {
 		updateRow(row);
 	});
+	if (const auto index = findRowIndex(row, RowIndex()); index.value >= 0) {
+		accessibilityChildStateChanged(index.value, {
+			.checked = true,
+			.selected = true,
+		});
+	}
 }
 
 void PeerListContent::setRowHidden(not_null<PeerListRow*> row, bool hidden) {
@@ -1603,6 +1630,50 @@ int PeerListContent::resizeGetHeight(int newWidth) {
 	return belowTop + _belowHeight;
 }
 
+void PeerListContent::keyPressEvent(QKeyEvent *e) {
+	if (e->key() == Qt::Key_Up) {
+		selectSkip(-1);
+		e->accept();
+	} else if (e->key() == Qt::Key_Down) {
+		selectSkip(1);
+		e->accept();
+	} else if (e->key() == Qt::Key_PageDown) {
+		selectSkipPage(height(), 1);
+		e->accept();
+	} else if (e->key() == Qt::Key_PageUp) {
+		selectSkipPage(height(), -1);
+		e->accept();
+	} else if (e->key() == Qt::Key_Return || e->key() == Qt::Key_Enter || e->key() == Qt::Key_Space) {
+		submitted();
+		e->accept();
+	} else {
+		e->ignore();
+	}
+}
+
+void PeerListContent::focusInEvent(QFocusEvent *e) {
+	RpWidget::focusInEvent(e);
+	if (!base::ScreenReaderState::Instance()->active()) {
+		return;
+	}
+	InvokeQueued(this, [=] {
+		if (!hasFocus()) {
+			return;
+		}
+		const auto count = shownRowsCount();
+		if (count <= 0) {
+			return;
+		}
+		const auto current = _selectedIndex.current();
+		if (current >= 0 && current < count) {
+			accessibilityChildFocused(current);
+			return;
+		}
+		setSelected({ RowIndex(0), 0 });
+		accessibilityChildFocused(0);
+	});
+}
+
 void PeerListContent::enterEventHook(QEnterEvent *e) {
 	setMouseTracking(true);
 }
@@ -2443,6 +2514,19 @@ PeerListRow *PeerListContent::getRow(RowIndex index) {
 	return nullptr;
 }
 
+const PeerListRow *PeerListContent::getRow(RowIndex index) const {
+	if (index.value >= 0) {
+		if (showingSearch()) {
+			if (index.value < _filterResults.size()) {
+				return _filterResults[index.value];
+			}
+		} else if (index.value < _rows.size()) {
+			return _rows[index.value].get();
+		}
+	}
+	return nullptr;
+}
+
 PeerListContent::RowIndex PeerListContent::findRowIndex(
 		not_null<PeerListRow*> row,
 		RowIndex hint) {
@@ -2491,3 +2575,97 @@ void PeerListContentDelegate::peerListShowRowMenu(
 		Fn<void(not_null<Ui::PopupMenu *>)> destroyed) {
 	_content->showRowMenu(row, highlightRow, std::move(destroyed));
 }
+
+QAccessible::Role PeerListContent::accessibilityRole() {
+	return QAccessible::List;
+}
+
+QString PeerListContent::accessibilityName() {
+	const auto fromUi = accessibleName();
+	return fromUi.isEmpty() ? _controller->accessibilityName() : fromUi;
+}
+
+Ui::AccessibilityState PeerListContent::accessibilityState() const {
+	return {};
+}
+
+int PeerListContent::accessibilityChildCount() const {
+	return shownRowsCount();
+}
+
+QAccessible::Role PeerListContent::accessibilityChildRole() const {
+	return QAccessible::ListItem;
+}
+
+QString PeerListContent::accessibilityChildName(int index) const {
+    if (index >= 0 && index < shownRowsCount()) {
+        const auto row = getRow(RowIndex(index));
+        if (!row) {
+            return QString();
+        }
+        if (!row->name().isEmpty()) {
+            return row->name().toString();
+        }
+        return const_cast<PeerListRow*>(row)->generateName();
+    }
+    return QString();
+}
+
+QAccessible::State PeerListContent::accessibilityChildState(int index) const {
+	auto state = QAccessible::State();
+	if (index >= 0 && index < shownRowsCount()) {
+		if (base::ScreenReaderState::Instance()->active()) {
+			state.focusable = true;
+		}
+		state.selectable = true;
+
+		const auto row = getRow(RowIndex(index));
+		if (row->checkable() && !row->special()) {
+			state.checkable = true;
+			state.checked = row->checked();
+			if (row->checked()) {
+				state.selected = true;
+			}
+		}
+		const auto top = getRowTop(RowIndex(index));
+		const auto bottom = top + _rowHeight;
+		if (bottom <= _visibleTop || top >= _visibleBottom) {
+			state.invisible = true;
+		}
+		if (index == _selectedIndex.current()) {
+			state.focused = true;
+			state.invisible = false;
+		}
+	}
+	return state;
+}
+
+QRect PeerListContent::accessibilityChildRect(int index) const {
+	if (index >= 0 && index < shownRowsCount()) {
+		const auto top = getRowTop(RowIndex(index));
+		return QRect(0, top, width(), _st.item.height);
+	}
+	return QRect();
+}
+
+int PeerListContent::accessibilityChildColumnCount(int row) const {
+	return 1;
+}
+
+QAccessible::Role PeerListContent::accessibilityChildSubItemRole() const {
+	return QAccessible::Cell;
+}
+
+QString PeerListContent::accessibilityChildSubItemName(int row, int column) const {
+	if (column == 0) {
+		return _controller->accessibilityName();
+	}
+	return QString();
+}
+
+QString PeerListContent::accessibilityChildSubItemValue(int row, int column) const {
+	if (column == 0) {
+		return accessibilityChildName(row);
+	}
+	return QString();
+}
diff --git a/Telegram/SourceFiles/boxes/peer_list_box.h b/Telegram/SourceFiles/boxes/peer_list_box.h
@@ -75,6 +75,7 @@ class PeerListRow {
 	// not by the row itself, so there is no setChecked() method.
 	// We can query the checked state from row, but before it is
 	// added to the box it is always false.
+	[[nodiscard]] bool checkable() const;
 	[[nodiscard]] bool checked() const;
 
 	[[nodiscard]] bool special() const {
@@ -596,6 +597,8 @@ class PeerListController : public PeerListSearchDelegate {
 		return _lifetime;
 	}
 
+	[[nodiscard]] virtual QString accessibilityName() const;
+
 	virtual ~PeerListController() = default;
 
 protected:
@@ -742,13 +745,28 @@ class PeerListContent : public Ui::RpWidget {
 
 	~PeerListContent();
 
+	QAccessible::Role accessibilityRole() override;
+	QString accessibilityName() override;
+	Ui::AccessibilityState accessibilityState() const override;
+	int accessibilityChildCount() const override;
+	QAccessible::Role accessibilityChildRole() const override;
+	QString accessibilityChildName(int index) const override;
+	QAccessible::State accessibilityChildState(int index) const override;
+	QRect accessibilityChildRect(int index) const override;
+	int accessibilityChildColumnCount(int row) const override;
+	QAccessible::Role accessibilityChildSubItemRole() const override;
+	QString accessibilityChildSubItemName(int row, int column) const override;
+	QString accessibilityChildSubItemValue(int row, int column) const override;
+
 protected:
 	int resizeGetHeight(int newWidth) override;
 	void visibleTopBottomUpdated(
 		int visibleTop,
 		int visibleBottom) override;
 
 	void paintEvent(QPaintEvent *e) override;
+	void keyPressEvent(QKeyEvent *e) override;
+	void focusInEvent(QFocusEvent *e) override;
 	void enterEventHook(QEnterEvent *e) override;
 	void leaveEventHook(QEvent *e) override;
 	void mouseMoveEvent(QMouseEvent *e) override;
@@ -821,6 +839,7 @@ class PeerListContent : public Ui::RpWidget {
 	void updateRow(RowIndex row);
 	int getRowTop(RowIndex row) const;
 	PeerListRow *getRow(RowIndex element);
+	const PeerListRow *getRow(RowIndex element) const;
 	RowIndex findRowIndex(
 		not_null<PeerListRow*> row,
 		RowIndex hint = RowIndex());
@@ -1127,7 +1146,13 @@ class PeerListBox
 	[[nodiscard]] rpl::producer<> noSearchSubmits() const;
 
 	void peerListSetTitle(rpl::producer<QString> title) override {
-		setTitle(std::move(title));
+		auto shared = rpl::duplicate(title);
+		setTitle(std::move(shared));
+		if (const auto c = content()) {
+			std::move(title) | rpl::on_next([=](const QString &t) {
+				c->setAccessibleName(t);
+			}, c->lifetime());
+		}
 	}
 	void peerListSetAdditionalTitle(rpl::producer<QString> title) override {
 		setAdditionalTitle(std::move(title));
diff --git a/Telegram/SourceFiles/boxes/peer_list_controllers.cpp b/Telegram/SourceFiles/boxes/peer_list_controllers.cpp
@@ -659,6 +659,10 @@ Main::Session &ContactsBoxController::session() const {
 	return *_session;
 }
 
+QString ContactsBoxController::accessibilityName() const {
+	return tr::lng_contacts_header(tr::now);
+}
+
 void ContactsBoxController::prepare() {
 	setSearchNoResultsText(tr::lng_blocked_list_not_found(tr::now));
 	delegate()->peerListSetSearchMode(PeerListSearchMode::Enabled);
@@ -958,6 +962,10 @@ QString ChooseRecipientBoxController::savedMessagesChatStatus() const {
 	return tr::lng_saved_forward_here(tr::now);
 }
 
+QString ChooseRecipientBoxController::accessibilityName() const {
+	return tr::lng_forward_choose(tr::now);
+}
+
 auto ChooseRecipientBoxController::createRow(
 		not_null<History*> history) -> std::unique_ptr<Row> {
 	const auto peer = history->peer;
@@ -1253,6 +1261,10 @@ std::unique_ptr<PeerListRow> ChooseTopicBoxController::createSearchRow(
 	return nullptr;
 }
 
+QString ChooseTopicBoxController::accessibilityName() const {
+	return tr::lng_forward_choose(tr::now);
+}
+
 std::unique_ptr<PeerListRow> ChooseTopicBoxController::MakeRow(
 		not_null<Data::ForumTopic*> topic) {
 	return std::make_unique<Row>(topic);
@@ -1358,6 +1370,10 @@ std::unique_ptr<PeerListRow> ChooseSublistBoxController::createSearchRow(
 	return nullptr;
 }
 
+QString ChooseSublistBoxController::accessibilityName() const {
+	return tr::lng_forward_choose(tr::now);
+}
+
 auto ChooseSublistBoxController::createRow(
 	not_null<Data::SavedSublist*> sublist)
 -> std::unique_ptr<PeerListRow> {
diff --git a/Telegram/SourceFiles/boxes/peer_list_controllers.h b/Telegram/SourceFiles/boxes/peer_list_controllers.h
@@ -255,6 +255,8 @@ class ContactsBoxController : public PeerListController {
 		return !_stories;
 	}
 
+	[[nodiscard]] QString accessibilityName() const override;
+
 	enum class SortMode {
 		Alphabet,
 		Online,
@@ -309,6 +311,8 @@ class ChooseRecipientBoxController
 
 	QString savedMessagesChatStatus() const override;
 
+	[[nodiscard]] QString accessibilityName() const override;
+
 protected:
 	void prepareViewHook() override;
 	std::unique_ptr<Row> createRow(not_null<History*> history) override;
@@ -364,6 +368,8 @@ class ChooseTopicBoxController final
 	void loadMoreRows() override;
 	std::unique_ptr<PeerListRow> createSearchRow(PeerListRowId id) override;
 
+	[[nodiscard]] QString accessibilityName() const override;
+
 	[[nodiscard]] static std::unique_ptr<PeerListRow> MakeRow(
 		not_null<Data::ForumTopic*> topic);
 
@@ -440,6 +446,8 @@ class ChooseSublistBoxController final
 	void loadMoreRows() override;
 	std::unique_ptr<PeerListRow> createSearchRow(PeerListRowId id) override;
 
+	[[nodiscard]] QString accessibilityName() const override;
+
 private:
 	void refreshRows(bool initial = false);
 	[[nodiscard]] std::unique_ptr<PeerListRow> createRow(
diff --git a/Telegram/SourceFiles/boxes/peers/edit_participants_box.cpp b/Telegram/SourceFiles/boxes/peers/edit_participants_box.cpp
diff --git a/Telegram/SourceFiles/boxes/peers/edit_participants_box.h b/Telegram/SourceFiles/boxes/peers/edit_participants_box.h
