Commit fa25d7d
committed
Fix duplicate subtitle widget in group call panel
The _subtitle.create() rpl chain calls setupMembers() synchronously
during the FlatLabel constructor. setupMembers() triggers geometry
updates that re-enter refreshTitle() while object_ptr::create() has
not yet assigned the new widget to _subtitle, so a second subtitle
is created and left as an orphaned visible child.
Moving setupMembers() before _subtitle.create() ensures _members
exists before the rpl chain fires, preventing the re-entrancy.1 parent dc6b9dd commit fa25d7d
1 file changed
Lines changed: 3 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2792 | 2792 | | |
2793 | 2793 | | |
2794 | 2794 | | |
| 2795 | + | |
| 2796 | + | |
| 2797 | + | |
2795 | 2798 | | |
2796 | 2799 | | |
2797 | 2800 | | |
| |||
0 commit comments