Fix duplicate subtitle widget in group call panel#30397
Open
paterkleomenis wants to merge 1 commit intotelegramdesktop:devfrom
Open
Fix duplicate subtitle widget in group call panel#30397paterkleomenis wants to merge 1 commit intotelegramdesktop:devfrom
paterkleomenis wants to merge 1 commit intotelegramdesktop:devfrom
Conversation
Contributor
|
pr conflicts... |
paterkleomenis
force-pushed
the
fix-subtitle-duplication
branch
from
6c6502a to
55d9a0e
Compare
Contributor
Author
i am sorry, now it should be good |
The _subtitle.create() rpl chain calls setupMembers() synchronously during the FlatLabel constructor. setupMembers() triggers geometry updates that re-enter refreshTitle() while object_ptr::create() has not yet assigned the new widget to _subtitle, so a second subtitle is created and left as an orphaned visible child. Moving setupMembers() before _subtitle.create() ensures _members exists before the rpl chain fires, preventing the re-entrancy.
paterkleomenis
force-pushed
the
fix-subtitle-duplication
branch
from
55d9a0e to
fa25d7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
_subtitle.create()rpl chain callssetupMembers()synchronously during the FlatLabel constructor.setupMembers()triggers geometry updates that re-enterrefreshTitle()whileobject_ptr::create()has not yet assigned the new widget to_subtitle, so a second subtitle is created and left as an orphaned visible child.Moving
setupMembers()before_subtitle.create()ensures_membersexists before the rpl chain fires, preventing the re-entrancy.