Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Telegram/SourceFiles/media/media_common.h
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ struct VideoQuality {

inline constexpr auto kSpeedMin = 0.5;
inline constexpr auto kSpeedMax = 2.5;
inline constexpr auto kSpeedDefault = 1.0;
inline constexpr auto kSpedUpDefault = 1.7;

[[nodiscard]] inline bool EqualSpeeds(float64 a, float64 b) {
Expand Down
4 changes: 4 additions & 0 deletions Telegram/SourceFiles/media/player/media_player_dropdown.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -779,6 +779,10 @@ void SpeedController::toggleDefault() {
_speedChanged.fire(speed());
}

void SpeedController::updateSpeedFromOutside(float64 newSpeed) {
setSpeed(newSpeed);
}

void SpeedController::setSpeed(float64 newSpeed) {
if (!(_isDefault = EqualSpeeds(newSpeed, 1.))) {
_speed = newSpeed;
Expand Down
3 changes: 2 additions & 1 deletion Telegram/SourceFiles/media/player/media_player_dropdown.h
Original file line number Diff line number Diff line change
Expand Up @@ -139,14 +139,15 @@ class SpeedController final : public WithDropdownController {

[[nodiscard]] rpl::producer<> saved() const;
[[nodiscard]] rpl::producer<float64> realtimeValue() const;
void updateSpeedFromOutside(float64 newSpeed);
void toggleDefault();

private:
void fillMenu(not_null<Ui::DropdownMenu*> menu) override;

[[nodiscard]] float64 speed() const;
[[nodiscard]] bool isDefault() const;
[[nodiscard]] float64 lastNonDefaultSpeed() const;
void toggleDefault();
void setSpeed(float64 newSpeed);
void setQuality(VideoQuality quality);
void save();
Expand Down
28 changes: 28 additions & 0 deletions Telegram/SourceFiles/media/view/media_view_playback_controls.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -75,11 +75,33 @@ PlaybackControls::PlaybackControls(
: 1.);
updateSpeedToggleQuality();

if (_speedToggle) {
_speedToggle->setAcceptBoth(true);
_speedToggle->setContextMenuPolicy(Qt::PreventContextMenu);
_speedToggle->clicks(
) | rpl::filter([](Qt::MouseButton button) {
return button == Qt::RightButton;
}) | rpl::on_next([=] {
if (_speedController) {
_speedController->toggleDefault();
} else {
updatePlaybackSpeed(Media::kSpeedDefault);
}
}, _speedToggle->lifetime());
}

if (const auto controller = _speedController.get()) {
controller->menuToggledValue(
) | rpl::on_next([=](bool toggled) {
_speedToggle->setActive(toggled);
}, _speedToggle->lifetime());

controller->realtimeValue(
) | rpl::on_next([=](float64 speed) {
_speedToggle->setSpeed(speed);
_delegate->playbackControlsSpeedChanged(speed);
resizeEvent(nullptr);
}, _speedToggle->lifetime());
}

_pictureInPicture->addClickHandler([=] {
Expand Down Expand Up @@ -229,6 +251,12 @@ void PlaybackControls::updateSpeedToggleQuality() {

void PlaybackControls::updatePlaybackSpeed(float64 speed) {
DEBUG_LOG(("Media playback speed: update to %1.").arg(speed));
if (_speedToggle) {
_speedToggle->setSpeed(speed);
}
if (_speedController) {
_speedController->updateSpeedFromOutside(speed);
}
_delegate->playbackControlsSpeedChanged(speed);
resizeEvent(nullptr);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ class PlaybackControls : public Ui::RpWidget {
void updatePlayback(const Player::TrackState &state);
void setLoadingProgress(int64 ready, int64 total);
void setInFullScreen(bool inFullScreen);
void updatePlaybackSpeed(float64 speed);
[[nodiscard]] bool hasMenu() const;
[[nodiscard]] bool dragging() const;

Expand All @@ -84,7 +85,6 @@ class PlaybackControls : public Ui::RpWidget {
[[nodiscard]] float64 countDownloadedTillPercent(
const Player::TrackState &state) const;

void updatePlaybackSpeed(float64 speed);
void updateVolumeToggleIcon();
void updateDownloadProgressPosition();

Expand Down