Fix accessibility for PeerList (NVDA Screen Reader)#30755
Open
HassanAlBarshoumy wants to merge 1 commit into
Open
Fix accessibility for PeerList (NVDA Screen Reader)#30755HassanAlBarshoumy wants to merge 1 commit into
HassanAlBarshoumy wants to merge 1 commit into
Conversation
|
|
HassanAlBarshoumy
force-pushed
the
fix-nvda-accessibility-peerlist
branch
from
9d69498 to
a9157a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a critical accessibility issue where NVDA and other screen readers fail to read the names of contacts, blocked users, and group members in the application.
It implements the missing QAccessible overrides for PeerListContent, allowing it to announce its ListItem children's name and status, and emit focus events when the selection changes via keyboard arrows or mouse.
Tested locally with NVDA and Windows accessibility features.